GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove SuspendJob and ResumeJob cmdlets from compilation by JamesWTruher · Pull Request #7650 · PowerShell/PowerShell

Conversation

@JamesWTruher

@JamesWTruher James Truher (JamesWTruher) commented Aug 28, 2018

Copy link
Copy Markdown
Collaborator

The classes for the cmdlets are present but the Cmdlet attribute has been removed. There is no reason why we should be compiling these files, and it very slightly impacts our code coverage numbers.

This can be taken for 6.2, there is no reason to take it for 6.1

PR Summary

Remove SuspendJob and ResumeJob from compilation

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher
Remove SuspendJob and ResumeJob sources from compilation
f45e25d 
The classes for the cmdlets are present but the Cmdlet attribute has been removed. There is no reason why we should be compiling these files, and it very slightly impacts our code coverage numbers.
@JamesWTruher
James Truher (JamesWTruher) requested a review from Dongbo Wang (daxian-dbw) August 28, 2018 18:12
@JamesWTruher
James Truher (JamesWTruher) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dan Travison (dantraMSFT) as code owners August 28, 2018 18:12
@JamesWTruher James Truher (JamesWTruher) changed the title Remove SuspendJob and ResumeJob sources from compilation Remove SuspendJob and ResumeJob cmdlets from compilation Aug 28, 2018
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Aug 28, 2018
View reviewed changes
Comment thread src/System.Management.Automation/System.Management.Automation.csproj
<Compile Remove="engine\remoting\commands\ReceivePSSession.cs" />
<Compile Remove="engine\remoting\commands\DisconnectPSSession.cs" />
<Compile Remove="engine\remoting\commands\ConnectPSSession.cs" />
<Compile Remove="engine\remoting\commands\CustomShellCommands.cs" />

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Aug 28, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ItemGroup is specific to non-windows. I think we need to remove these for all platforms

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JamesWTruher James Truher (JamesWTruher) Aug 28, 2018

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely should be all platforms to remove.
fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher
Move 'compile remove' statements out of exclusion from Non-Windows to…
5e3c50a 
… exclusion for all
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Aug 28, 2018
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) approved these changes Aug 29, 2018
View reviewed changes
@TravisEz13 Travis Plunk (TravisEz13) assigned Dongbo Wang (daxian-dbw) Aug 29, 2018
dantraMSFT
Dan Travison (dantraMSFT) approved these changes Aug 30, 2018
View reviewed changes
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Aug 30, 2018
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 6d74298 into PowerShell:master Aug 30, 2018
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Aug 31, 2018
@JamesWTruher @TravisEz13
Remove 'Suspend-Job' and 'Resume-Job' cmdlets from compilation (#7650)
727f2a0 
The classes for the cmdlets are present but the Cmdlet attribute has been removed. There is no reason why we should be compiling these files, and it very slightly impacts our code coverage numbers.
@TravisEz13 Travis Plunk (TravisEz13) added this to the v6.1.0 milestone Aug 31, 2018
@JamesWTruher
James Truher (JamesWTruher) deleted the jameswtruher/removeobsoletejobcmdlets branch September 23, 2023 05:34
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@JamesWTruher @daxian-dbw
Remove 'Suspend-Job' and 'Resume-Job' cmdlets from compilation (Power…
843972b 
…Shell#7650)

The classes for the cmdlets are present but the Cmdlet attribute has been removed. There is no reason why we should be compiling these files, and it very slightly impacts our code coverage numbers.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@JamesWTruher @TravisEz13
Remove 'Suspend-Job' and 'Resume-Job' cmdlets from compilation (Power…
7e747ec 
…Shell#7650)

The classes for the cmdlets are present but the Cmdlet attribute has been removed. There is no reason why we should be compiling these files, and it very slightly impacts our code coverage numbers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
+1 more reviewer
@dantraMSFT Dan Travison (dantraMSFT) dantraMSFT approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

v6.1.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JamesWTruher @daxian-dbw @TravisEz13 @dantraMSFT @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.