GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Change logic for downloading zip files based on job id by JamesWTruher · Pull Request #7653 · PowerShell/PowerShell

Conversation

@JamesWTruher

@JamesWTruher James Truher (JamesWTruher) commented Aug 28, 2018

Copy link
Copy Markdown
Collaborator

PR Summary

the logic we used previously to download the test artifacts no longer works because we have specific jobs for building in AppVeyor. This PR calculates the path for the zip downloads

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher James Truher (JamesWTruher) added the WG-Quality-Test issues in a test or in test infrastructure label Aug 28, 2018
@JamesWTruher James Truher (JamesWTruher) assigned Aditya Patwardhan (adityapatwardhan) Aug 28, 2018
@JamesWTruher
James Truher (JamesWTruher) requested a review from Aditya Patwardhan (adityapatwardhan) August 28, 2018 22:39
@JamesWTruher
James Truher (JamesWTruher) requested review from Travis Plunk (TravisEz13), Andrew (anmenaga), Dan Travison (dantraMSFT) and Dongbo Wang (daxian-dbw) as code owners August 28, 2018 22:39
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Aug 28, 2018
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) approved these changes Aug 29, 2018
View reviewed changes
anmenaga
Andrew (anmenaga) approved these changes Aug 29, 2018
View reviewed changes
@JamesWTruher
Change logic for downloading zip files based on job id
681946a
@JamesWTruher
James Truher (JamesWTruher) force-pushed the jameswtruher/CodeCoverageJobFix branch from 007aae9 to 681946a Compare August 29, 2018 21:46
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 30, 2018

Copy link
Copy Markdown
Member

Restarted appveyor.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit bc1aac7 into PowerShell:master Aug 30, 2018
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Aug 31, 2018
@JamesWTruher @TravisEz13
Change logic for downloading zip files based on job id (#7653)
087de5b
@TravisEz13 Travis Plunk (TravisEz13) added this to the v6.1.0 milestone Aug 31, 2018
@JamesWTruher
James Truher (JamesWTruher) deleted the jameswtruher/CodeCoverageJobFix branch September 23, 2023 05:34
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@JamesWTruher @adityapatwardhan
Change logic for downloading zip files based on job id (PowerShell#7653)
0c6ff5b
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@JamesWTruher @TravisEz13
Change logic for downloading zip files based on job id (PowerShell#7653)
32260de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@dantraMSFT Dan Travison (dantraMSFT) Awaiting requested review from dantraMSFT
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

WG-Quality-Test issues in a test or in test infrastructure

Projects

None yet

Milestone

v6.1.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JamesWTruher @adityapatwardhan @TravisEz13 @anmenaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.