GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Cleanup FileSystemProvider from runtime checks by iSazonov · Pull Request #7655 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Aug 29, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Address second part of #2349

  • Replace runtime checks with compile time checks.
  • Remove unneeded methods.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov
Cleanup FileSystemProvider from runtime checks
34399f0 
Replace runtime checks with compile time checks.
Remove unneeded methods.
@iSazonov Ilya (iSazonov) self-assigned this Aug 29, 2018
@iSazonov
Ilya (iSazonov) requested review from Dongbo Wang (daxian-dbw) and Rob Holt (rjmholt) August 29, 2018 12:29
@iSazonov
Ilya (iSazonov) requested review from Bruce Payette (BrucePay) and Andrew (anmenaga) as code owners August 29, 2018 12:29
Ilya (iSazonov) added 6 commits August 29, 2018 18:12
@iSazonov
Revert "Cleanup FileSystemProvider from runtime checks"
651e1b5 
This reverts commit 34399f0.
@iSazonov
Step 1
125e4be
@iSazonov
Step 2
6a06f1c
@iSazonov
Step 3
10e81eb
@iSazonov
Step 4
8b881d2
@iSazonov
Step 5
b8e5322
@iSazonov Ilya (iSazonov) closed this Aug 29, 2018
@iSazonov Ilya (iSazonov) reopened this Aug 29, 2018
@iSazonov

Ilya (iSazonov) commented Aug 29, 2018

Copy link
Copy Markdown
Collaborator Author

:-) I wonder that my first all-in-one commit failed and I had to split on steps.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rjmholt
Rob Holt (rjmholt) approved these changes Aug 29, 2018
View reviewed changes

@rjmholt Rob Holt (rjmholt) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me -- much nicer!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs
}

#endif
return InternalGetTarget(fileSysInfo.FullName);

@rjmholt Rob Holt (rjmholt) Aug 29, 2018

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the definition for this method is gone but a call remains. Is there another definition somewhere?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Aug 30, 2018

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, one - wih handle parameter, second with string parameter. First one was removed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rjmholt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@rjmholt Rob Holt (rjmholt) Aug 30, 2018

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anmenaga

Andrew (anmenaga) commented Sep 5, 2018

Copy link
Copy Markdown

Dongbo Wang (@daxian-dbw) can you please review this? Thanks.

Ilya (@iSazonov) please do a [feature] test run for this. Thanks.
iSazonov and daxian-dbw reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov
[Feature]
08e3d7f
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Sep 8, 2018
View reviewed changes
@iSazonov
Ilya (iSazonov) merged commit b8fb553 into PowerShell:master Sep 8, 2018
@iSazonov
Ilya (iSazonov) deleted the cleanup-filesystemprovider-symlinks branch September 8, 2018 19:40
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Sep 8, 2018
FindFirstFileName and FindNextFileName are available in NanoServer and IoT now, so we should enable the usage of them in powershell core #2349
Closed
1 of 2 tasks
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Sep 10, 2018
@iSazonov @TravisEz13
Cleanup FileSystemProvider from runtime checks (#7655)
433ec46 
Replace runtime checks with compile time checks.
Remove unneeded methods.
@TravisEz13 Travis Plunk (TravisEz13) added this to the v6.1.0 milestone Sep 10, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov
Cleanup FileSystemProvider from runtime checks (PowerShell#7655)
4f0d0a2 
Replace runtime checks with compile time checks.
Remove unneeded methods.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov @TravisEz13
Cleanup FileSystemProvider from runtime checks (PowerShell#7655)
eaef6e0 
Replace runtime checks with compile time checks.
Remove unneeded methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
+1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

v6.1.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iSazonov @anmenaga @daxian-dbw @rjmholt @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.