GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Change locale of mdspell to en-US by adityapatwardhan · Pull Request #7671 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Aug 30, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fix #6736

PR Summary

Update the locale to use en-us for mdspell checker.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Travis Plunk (TravisEz13) and Rob Holt (rjmholt) August 30, 2018 22:29
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Andrew (anmenaga), Dan Travison (dantraMSFT) and Dongbo Wang (daxian-dbw) as code owners August 30, 2018 22:29
anmenaga
Andrew (anmenaga) approved these changes Aug 30, 2018
View reviewed changes
@rjmholt

Rob Holt (rjmholt) commented Aug 30, 2018

Copy link
Copy Markdown
Collaborator

Looks like Travis is failing because of the spellcheck. Maybe worth regenerating the spelling exceptions file for this PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) force-pushed the FixMdSpellLocale branch 2 times, most recently from 4aa2e85 to d06e882 Compare August 31, 2018 00:40
TravisEz13
Travis Plunk (TravisEz13) reviewed Aug 31, 2018
View reviewed changes
Comment thread .spelling Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Aug 31, 2018
View reviewed changes
Aditya Patwardhan (adityapatwardhan) added 6 commits August 31, 2018 10:45
@adityapatwardhan
Change locale of mdspell to en-US
56185f1
@adityapatwardhan
Update spelling file
53f6e65
@adityapatwardhan
Update spelling file
aa607e0
@adityapatwardhan
Add new spellings ignore
b762362
@adityapatwardhan
Sorted the spellings file
2258424
@adityapatwardhan
Fixing CI failure
c4a14cc
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) force-pushed the FixMdSpellLocale branch from 4a4f1a2 to c4a14cc Compare August 31, 2018 17:48
@adityapatwardhan
Fix document for markdown errors and change .spelling
32d4ce7
@TravisEz13
Travis Plunk (TravisEz13) merged commit d487ff9 into PowerShell:master Aug 31, 2018
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the FixMdSpellLocale branch September 4, 2018 23:00
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Sep 5, 2018
@adityapatwardhan @TravisEz13
Change locale of mdspell to en-US (#7671)
994abcc 
Update the locale to use en-us for mdspell checker.
@TravisEz13 Travis Plunk (TravisEz13) added this to the v6.1.0 milestone Sep 7, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan @TravisEz13
Change locale of mdspell to en-US (PowerShell#7671)
df6f7a2 
Update the locale to use en-us for mdspell checker.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan @TravisEz13
Change locale of mdspell to en-US (PowerShell#7671)
6c5df67 
Update the locale to use en-us for mdspell checker.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@rjmholt Rob Holt (rjmholt) Awaiting requested review from rjmholt
@dantraMSFT Dan Travison (dantraMSFT) Awaiting requested review from dantraMSFT
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v6.1.0

Development

Successfully merging this pull request may close these issues.

Convert to using mdspell with en-US

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@adityapatwardhan @rjmholt @TravisEz13 @anmenaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.