GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix file blocking issue with webcmdlets by Claustn · Pull Request #7676 · PowerShell/PowerShell

Conversation

@Claustn

@Claustn Claus T Nielsen (Claustn) commented Aug 31, 2018 •
edited by iSazonov
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Resolve #7669.

Allows multiple uploads of the same file in parallel

This PR changes how -InFile parameter on the Web cmdlets open file handles. Previously the file was opened with ShareAccess None, meaning that the file was locked, resulting in that you, for instance, was not able to upload the same file to multiple destinations in parallel.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
powercode reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Claustn
Claus T Nielsen (Claustn) requested review from James Truher (JamesWTruher), Paul Higinbotham (PaulHigin) and Dan Travison (dantraMSFT) as code owners August 31, 2018 14:38
@Claustn Claus T Nielsen (Claustn) mentioned this pull request Aug 31, 2018
Webcmdlets using -InFile parameter locks file #7669
Closed
@iSazonov
Ilya (iSazonov) requested a review from Mark Kraus (markekraus) August 31, 2018 14:54
@iSazonov Ilya (iSazonov) self-assigned this Aug 31, 2018
@iSazonov Ilya (iSazonov) changed the title Fix file blocking issue with webcmdlets using -InFile Issue #7669 Fix file blocking issue with webcmdlets Aug 31, 2018
@iSazonov

Ilya (iSazonov) commented Aug 31, 2018

Copy link
Copy Markdown
Collaborator

Claus T Nielsen (@Claustn) Thanks! I slightly corrected the PR title and description.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Aug 31, 2018
View reviewed changes
@iSazonov
Ilya (iSazonov) requested a review from Steve Lee (SteveL-MSFT) August 31, 2018 14:58
@iSazonov

Ilya (iSazonov) commented Aug 31, 2018

Copy link
Copy Markdown
Collaborator

Claus T Nielsen (@Claustn) Please rename your commit - start title with [Feature] or add new empty commit with title [Feature] - this will run full test set.
markekraus reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
powercode
Staffan Gustafsson (powercode) reviewed Aug 31, 2018
View reviewed changes

@powercode Staffan Gustafsson (powercode) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov

Ilya (iSazonov) commented Aug 31, 2018

Copy link
Copy Markdown
Collaborator

CI Appveyor temporary failed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Aug 31, 2018
View reviewed changes

@PaulHigin Paul Higinbotham (PaulHigin) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markekraus
Mark Kraus (markekraus) reviewed Aug 31, 2018
View reviewed changes

@markekraus Mark Kraus (markekraus) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My approval is pending successful completion of all [feature] tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Claus T Nielsen
[feature] fix file blocking issue with webcmdlets using infile
5f70274
@Claustn
Claus T Nielsen (Claustn) force-pushed the fix/webcmdlets_infile_blocking branch from c32a3a5 to 5f70274 Compare September 1, 2018 10:05
Claus T Nielsen
[feature]
5b6e7c7
@iSazonov
Ilya (iSazonov) merged commit eb92b14 into PowerShell:master Sep 1, 2018
@iSazonov

Ilya (iSazonov) commented Sep 1, 2018

Copy link
Copy Markdown
Collaborator

Claus T Nielsen (@Claustn) Thanks for discovering the issue and fixing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Sep 5, 2018
@Claustn @TravisEz13
Fix file blocking issue with webcmdlets (#7676)
56f1db3
@TravisEz13 Travis Plunk (TravisEz13) added this to the v6.1.0 milestone Sep 7, 2018
@thezim Greg Zimmerman (thezim) mentioned this pull request Oct 1, 2018
Bug: Add-Type needs write-access when compiling from source #7914
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@Claustn @iSazonov
Fix file blocking issue with webcmdlets (PowerShell#7676)
4b7556c
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@Claustn @TravisEz13
Fix file blocking issue with webcmdlets (PowerShell#7676)
b58dcab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@dantraMSFT Dan Travison (dantraMSFT) Awaiting requested review from dantraMSFT
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
+3 more reviewers
@powercode Staffan Gustafsson (powercode) powercode left review comments
@markekraus Mark Kraus (markekraus) markekraus left review comments
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

v6.1.0

Development

Successfully merging this pull request may close these issues.

Webcmdlets using -InFile parameter locks file

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Claustn @iSazonov @powercode @markekraus @PaulHigin @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.