GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve markdown Formatting of beginners guide by fbehrens · Pull Request #7684 · PowerShell/PowerShell

Conversation

@fbehrens

@fbehrens fkbs (fbehrens) commented Sep 1, 2018 •
edited by anmenaga
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I just improved the formatting of this markdown document.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • [NA] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Sep 1, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Sep 3, 2018
View reviewed changes
@iSazonov
Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Aditya Patwardhan (adityapatwardhan) September 3, 2018 05:44
@iSazonov Ilya (iSazonov) assigned Aditya Patwardhan (adityapatwardhan) Sep 3, 2018
@anmenaga

Andrew (anmenaga) commented Sep 5, 2018

Copy link
Copy Markdown

I edited description and filled necessary checkboxes of the description template.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Sep 5, 2018
View reviewed changes
Comment thread docs/learning-powershell/powershell-beginners-guide.md Outdated

@SteveL-MSFT Steve Lee (SteveL-MSFT) Sep 5, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be:
```powershell

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anmenaga

Andrew (anmenaga) commented Sep 7, 2018

Copy link
Copy Markdown

Steve Lee (@SteveL-MSFT) your feedback was addressed; please take a look again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anmenaga
Andrew (anmenaga) approved these changes Sep 7, 2018
View reviewed changes
alexandair
Aleksandar Nikolić (alexandair) reviewed Sep 7, 2018
View reviewed changes
Comment thread docs/learning-powershell/powershell-beginners-guide.md Outdated

@alexandair Aleksandar Nikolić (alexandair) Sep 7, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove a space between backticks and "powershell".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Sep 7, 2018
View reviewed changes
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Sep 17, 2018

Copy link
Copy Markdown
Member

fkbs (@fbehrens) Please rebase or send in a new commit to trigger PowerShell-CI-spelling CI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
fkbs (fbehrens) added 3 commits September 20, 2018 23:09
@fbehrens
Improve markdown Formatting of beginners guide
17f8317
@fbehrens
change case to ```powershell for all code blocks
0272aa6
@fbehrens
remove space between backticks and powershell
cf5f886
@fbehrens
fkbs (fbehrens) force-pushed the improve_guide branch from 6ca050e to cf5f886 Compare September 20, 2018 21:09
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Sep 24, 2018
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 8463444 into PowerShell:master Sep 24, 2018
@fbehrens

fkbs (fbehrens) commented Sep 26, 2018

Copy link
Copy Markdown
Contributor Author

Thanks for merging :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Sep 26, 2018

Copy link
Copy Markdown
Collaborator

fkbs (@fbehrens) Thanks for your contribution!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@fbehrens @adityapatwardhan
Improve markdown Formatting of beginners guide (PowerShell#7684)
cac2ca4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
+2 more reviewers
@alexandair Aleksandar Nikolić (alexandair) alexandair left review comments
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@fbehrens @msftclas @anmenaga @adityapatwardhan @iSazonov @alexandair @SteveL-MSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.