GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Empty line follow the copyright header by iSazonov · Pull Request #7706 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Sep 5, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Correct CONTRIBUTION.md

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov
Empty line follow the copyright header
c024b77
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Sep 5, 2018
@iSazonov
Ilya (iSazonov) requested a review from Travis Plunk (TravisEz13) September 5, 2018 05:40
@iSazonov
Ilya (iSazonov) requested a review from Joey Aiello (joeyaiello) as a code owner September 5, 2018 05:40
@iSazonov Ilya (iSazonov) mentioned this pull request Sep 5, 2018
Add a paragraph on files.wxs updating #7695
Merged
7 of 11 tasks
anmenaga
Andrew (anmenaga) approved these changes Sep 5, 2018
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) approved these changes Sep 5, 2018
View reviewed changes
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Sep 7, 2018
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 0c3ada7 into PowerShell:master Sep 7, 2018
@iSazonov
Ilya (iSazonov) deleted the contribution-md-empty-line branch September 8, 2018 18:16
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Sep 10, 2018
@iSazonov @TravisEz13
Update CONTRIBUTION.md about adding an empty line after the copyright…
bec64a0 
… header (#7706)
@TravisEz13 Travis Plunk (TravisEz13) added this to the v6.1.0 milestone Sep 10, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov @daxian-dbw
Update CONTRIBUTION.md about adding an empty line after the copyright…
ebff040 
… header (PowerShell#7706)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov @TravisEz13
Update CONTRIBUTION.md about adding an empty line after the copyright…
deabf9c 
… header (PowerShell#7706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@joeyaiello Joey Aiello (joeyaiello) Awaiting requested review from joeyaiello
+1 more reviewer
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

v6.1.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iSazonov @daxian-dbw @TravisEz13 @anmenaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.