GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix pipeline test where SmtpServer key was set wrong in pipeline object by ThreeFive-O · Pull Request #7745 · PowerShell/PowerShell

Conversation

@ThreeFive-O

@ThreeFive-O ThreeFive-O commented Sep 9, 2018

Copy link
Copy Markdown
Contributor

PR Summary

Fix #7592

Fix pipeline test logic for Send-MailMessage

  • Fix SmtpServer key (was $SmtpServer) in hashtable object.
  • Removed double quotes for all keys in hashtable object.

NOTE: The test will still fail after this PR, because issue #7591 has to be fixed too.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ThreeFive-O
Fix pipeline test where SmtpServer key was set wrong in pipeline object
83bd7a4
@iSazonov
Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Dan Travison (dantraMSFT) September 10, 2018 07:09
iSazonov
Ilya (iSazonov) approved these changes Sep 10, 2018
View reviewed changes
@iSazonov Ilya (iSazonov) self-assigned this Sep 10, 2018
anmenaga
Andrew (anmenaga) approved these changes Sep 10, 2018
View reviewed changes
dantraMSFT
Dan Travison (dantraMSFT) approved these changes Sep 10, 2018
View reviewed changes
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Sep 10, 2018
View reviewed changes
@iSazonov
Ilya (iSazonov) merged commit 32cdbe6 into PowerShell:master Sep 11, 2018
@ThreeFive-O
ThreeFive-O deleted the Fix7592 branch September 11, 2018 10:21
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@ThreeFive-O @iSazonov
Fix pipeline test where SmtpServer key was set wrong in pipeline obje…
e844770 
…ct (PowerShell#7745)

Fix SmtpServer key (was $SmtpServer) in hashtable object.
Removed double quotes for all keys in hashtable object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
+2 more reviewers
@anmenaga Andrew (anmenaga) anmenaga approved these changes
@dantraMSFT Dan Travison (dantraMSFT) dantraMSFT approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Send-MailMessage.Tests.ps1 - failure in 'Can send mail message from user to self using pipeline '

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ThreeFive-O @daxian-dbw @anmenaga @dantraMSFT @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.