GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix .NET adapter to be able to get members from System.IntPtr by daxian-dbw · Pull Request #7808 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Sep 17, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Fix .NET adapter to be able to get members from System.IntPtr.
The type System.IntPtr has an explicit cast operator defined that takes a pointer type System.void* parameter. We didn't handle that type properly in GetPSMethodProjectedType.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Dongbo Wang (daxian-dbw) requested review from Bruce Payette (BrucePay), Aditya Patwardhan (adityapatwardhan) and Ilya (iSazonov) September 17, 2018 23:34
@daxian-dbw
Dongbo Wang (daxian-dbw) force-pushed the fix branch from c774ee2 to 74761bd Compare September 17, 2018 23:35
@iSazonov

Ilya (iSazonov) commented Sep 18, 2018

Copy link
Copy Markdown
Collaborator

https://powershell.visualstudio.com/PowerShell/_build/results?buildId=1979&view=logs
I already saw such error. Have we a problem with the CI?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) reviewed Sep 18, 2018
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Member.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/MshMemberInfo.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) mentioned this pull request Sep 18, 2018
New X509Certificate2 crashes PowerShell with AccessViolationException when certain properties are referenced #7806
Closed
@iSazonov

Ilya (iSazonov) commented Sep 19, 2018

Copy link
Copy Markdown
Collaborator

PowerShell-CI-Linux issue is in many PRs :-(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Sep 19, 2018
View reviewed changes
@anmenaga

Andrew (anmenaga) commented Sep 19, 2018

Copy link
Copy Markdown

Travis Plunk (@TravisEz13) fixed PowerShell-CI-linux error yesterday:
Could not get lock /var/lib/dpkg/lock - open
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Sep 19, 2018

Copy link
Copy Markdown
Member Author

Clicking 'details' on the Linux-CI gives me Sorry! Our services aren't available right now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Sep 19, 2018
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Sep 19, 2018

Copy link
Copy Markdown
Member

I started a rebuild of the linux CI. You may need to rebase. The error indicates you code is out of date.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Sep 19, 2018

Copy link
Copy Markdown
Member

Yes, you need to rebase.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
[Feature] Fix .NET adapter to be able to get members from System.IntPtr
2c3575f
@daxian-dbw
Dongbo Wang (daxian-dbw) force-pushed the fix branch from 74761bd to 2c3575f Compare September 19, 2018 23:11
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Sep 19, 2018

Copy link
Copy Markdown
Member Author

Rebased. Will wait on the CIs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) self-assigned this Sep 20, 2018
@iSazonov
Ilya (iSazonov) merged commit b6d12a3 into PowerShell:master Sep 20, 2018
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the fix branch September 20, 2018 05:07
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Sep 20, 2018

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) Thanks for merging this PR. Just a gentle reminder: when squashing a PR, check the commit title to make sure unneeded tags are removed, such as [Feature] in this case 😄
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) mentioned this pull request Jan 28, 2019
Formatter throws when object has a pointer property #8765
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @iSazonov
[Feature] Fix .NET adapter to be able to get members from System.IntP…
722c122 
…tr (PowerShell#7808)

The type System.IntPtr has an explicit cast operator defined that takes a pointer type System.void* parameter. Now we handle that type properly in GetPSMethodProjectedType.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@daxian-dbw @iSazonov @anmenaga @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.