GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — Add C#-style type accelerators and suffixes for ushort, uint, ulong, and short literals by vexx32 · Pull Request #7813 · PowerShell/PowerShell Conversation
|
|
Ilya (@iSazonov) I think this is tidier now. shudders I need to take a rebasing class! 😝 The remaining build errors appear to be build environment errors unrelated to this PR. ^^ The CodeFactor issues are (I think) not particularly serious, and I have a follow-up PR that will address the vast majority of those coming shortly. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Rain Sallow (/u/ta11ow) (@vexx32) To rebase you can use the pattern: # rebase pull request on top of master git chechout <branch> git fetch PowerShell master git pull --rebase PowerShell master git push -f You can catch a conflict but it is another story. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Reopened to restart CIs. Looks all good, I guess the Linux issues were resolved. Ilya (@iSazonov) I have never had the good fortune to get a rebase to work without painstaking editing at every step along the way. Not sure why... I think I must be doing it wrong somehow. I need to read up on it! 😄 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Dongbo Wang (@daxian-dbw) Could you please look th PR? Rain Sallow (/u/ta11ow) (@vexx32) want to continue working on the code in follow PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
About the comments regarding the tests, I think it makes sense to keep some of the existing tests. They can be put only in the #Standard numeric notation section, not in other sections for the new notations.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Marked this PR with |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Rain Sallow (/u/ta11ow) (@vexx32) I'm trying to tidy the PR description because the documentation work that follows up will need the accurate information.
By looking into the code, the suffix I copied the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Dongbo Wang (@daxian-dbw) Yes, the automatic step-up to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Dongbo Wang (@daxian-dbw) I think I got them all, but let me know if I missed anything! 😄 PR description has been cleaned up and made hopefully useful as a jumping off point for some proper documentation. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
For Thoroughness!
There was an error while loading. Please reload this page.
|
Aww, I was enjoying the all-green. Appveyor's failing on a Test-Connection due to timeout. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Rain Sallow (/u/ta11ow) (@vexx32) for your contribution! I will restart the AppVeyor CI.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yay! 😄 Now I can get the next one ready for Hacktoberfest 😉 AppVeyor's still having difficulty with Test-Connection, it seems... |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…and short literals (PowerShell#7813) [breaking change] Add the following type accelerators: [short], [ushort], [uint], [ulong]. Add the following numeric literal suffixes: - 'u' suffix (uint/ulong) - 's' suffix (short) - 'ul' suffix (ulong) - 'us' suffix (ushort)
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
PowerShell doesn't understand unsigned numbers
There was an error while loading. Please reload this page.