GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — remove badges for master build as it reflects last PR by SteveL-MSFT · Pull Request #7816 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Sep 18, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

The current README.md has badges showing the status of build of master branch, but this reflects the last submitted PR which is temporal. Depending on when you load the page, someone could have a broken build in an un-merged PR. This is not actionable from the README.md as the PR submitted would be fixing it in their PR. This row of badges is more confusing than helpful.

Fix is to remove that row of badges. Only the nightly badges are useful which are post PR merges.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Dongbo Wang (daxian-dbw) Sep 18, 2018
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested review from Travis Plunk (TravisEz13) and Dongbo Wang (daxian-dbw) September 18, 2018 22:07
TravisEz13
Travis Plunk (TravisEz13) approved these changes Sep 18, 2018
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Sep 18, 2018

Copy link
Copy Markdown
Member

#7817 will workaround the failure in linux CI

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SteveL-MSFT @TravisEz13
remove badges for master build as it reflects last PR which is not ac…
dd9cef6
…tionable from the README file
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the remove-master-badges branch from 2235b6c to dd9cef6 Compare September 19, 2018 00:16
@TravisEz13

Travis Plunk (TravisEz13) commented Sep 19, 2018

Copy link
Copy Markdown
Member

I rebased tho branch to pickup the CI fix from #7817

SteveL-MSFT reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13
Travis Plunk (TravisEz13) merged commit 985c238 into PowerShell:master Sep 19, 2018
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the remove-master-badges branch March 10, 2020 21:01
@xtqqczze

xtqqczze commented May 14, 2020

Copy link
Copy Markdown
Contributor

Steve Lee (@SteveL-MSFT) this PR left a few orphan link definitions, e.g. [az-windows-image], PR #12656 removes all unused link definitions from markdown files.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @TravisEz13
Remove badges for master build as it reflects last PR which is not ac…
4d4c0ac
…tionable from the README file (PowerShell#7816)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@SteveL-MSFT @TravisEz13 @xtqqczze @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.