GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update PowerShellGet to 2.0.0 by SteveL-MSFT · Pull Request #7831 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Sep 20, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Update version of PowerShellGet to 2.0.0

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Aditya Patwardhan (adityapatwardhan) Sep 20, 2018
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested a review from Aditya Patwardhan (adityapatwardhan) September 20, 2018 18:11
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested review from Travis Plunk (TravisEz13), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners September 20, 2018 18:11
@anmenaga

Andrew (anmenaga) commented Sep 20, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

I think Travis Plunk (@TravisEz13) mentioned to me that there is some functionality in VSTS to detect these things (updated dependency versions)...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anmenaga
Andrew (anmenaga) approved these changes Sep 20, 2018
View reviewed changes
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Sep 20, 2018

Copy link
Copy Markdown
Member

PackageManagement tests are part of Feature tests. Please push an empty commit with [Feature].
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the psget-20 branch from 9bfa8b5 to f0df32b Compare September 20, 2018 21:13
@TravisEz13

Travis Plunk (TravisEz13) commented Sep 20, 2018

Copy link
Copy Markdown
Member

It looks like the PowerShellGet tests need to be updated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Sep 20, 2018

Copy link
Copy Markdown
Member Author

Manikyam Bavandla (@bmanikm) can you look at the test failures?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Sep 21, 2018

Copy link
Copy Markdown
Member

The Package Reference from package.tests.ps1 fails because NJsonSchema updates the revision number again. The revision number is incremented about every week.

I updated to the latest review in PR #7834. At the same time, we need to think about how to not get interrupted too much by this special package.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Sep 21, 2018

Copy link
Copy Markdown
Member Author

Dongbo Wang (@daxian-dbw) should we special case NJsonSchema to only look at major.minor?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bmanikm

Manikyam Bavandla (bmanikm) commented Sep 21, 2018

Copy link
Copy Markdown
Contributor

Steve Lee (@SteveL-MSFT) I have updated the PowerShellGet tests, it looks like the new test failures are not related to PowerShellGet, please take a look at the new test failures.
SteveL-MSFT reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) self-assigned this Sep 21, 2018
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the psget-20 branch from d2592b1 to 9b5a245 Compare September 21, 2018 21:52
@TravisEz13

Travis Plunk (TravisEz13) commented Sep 21, 2018

Copy link
Copy Markdown
Member

rebased the PR to pick up fixes for test failures
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Steve Lee (SteveL-MSFT) and others added 2 commits September 24, 2018 10:52
@SteveL-MSFT @adityapatwardhan
[feature]
6ab337d 
update PSGet to 2.0.0
@bmanikm @adityapatwardhan
[Feature] Update PowerShellGet tests as per PowerShellGet 2.0.0 changes
7de2720
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) force-pushed the psget-20 branch from 9b5a245 to 7de2720 Compare September 24, 2018 17:53
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Sep 24, 2018

Copy link
Copy Markdown
Member

Rebase and pushed to update package references.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Sep 24, 2018
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 769ba7b into PowerShell:master Sep 24, 2018
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 14, 2019
Travis Plunk (TravisEz13) added a commit to TravisEz13/PowerShell that referenced this pull request May 14, 2019
@TravisEz13
Get PowerShellGet tests working (PowerShell#7831)
34f0ddf
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the psget-20 branch March 10, 2020 21:01
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @adityapatwardhan
Update PowerShellGet to 2.0.0 (PowerShell#7831)
cd7705a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
+1 more reviewer
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@SteveL-MSFT @anmenaga @adityapatwardhan @TravisEz13 @daxian-dbw @bmanikm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.