GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — update markdown tests by TravisEz13 · Pull Request #7838 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Sep 21, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

update markdown tests

  • explicitly use gulp 4.0 beta because 3.9 depends on a vulnerable package

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Travis Plunk (TravisEz13) requested a review from Rob Holt (rjmholt) September 21, 2018 21:37
rjmholt
Rob Holt (rjmholt) approved these changes Sep 21, 2018
View reviewed changes

@rjmholt Rob Holt (rjmholt) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, but it's non-blocking.

Otherwise, LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/common/markdown/markdown.tests.ps1 Outdated

@rjmholt Rob Holt (rjmholt) Sep 21, 2018

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a temporary change, or should we just take the if-statement out?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Sep 21, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this change. It was to allow local testing of the change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Travis Plunk (TravisEz13) added 2 commits September 21, 2018 15:29
@TravisEz13
update markdown tests
9d20231
@TravisEz13
undo change to allow local testing
87b70eb
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the update_markdown_tests branch from 6693515 to 87b70eb Compare September 21, 2018 22:29
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Sep 21, 2018
View reviewed changes
@TravisEz13
update njsonschema reference
95062c8
@TravisEz13
Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan) and Andrew (anmenaga) as code owners September 21, 2018 23:24
anmenaga
Andrew (anmenaga) approved these changes Sep 21, 2018
View reviewed changes
Travis Plunk (TravisEz13) added 6 commits September 21, 2018 17:25
@TravisEz13
replace old API call
e2dd31f
@TravisEz13
improve results format
c6777d9
@TravisEz13
update docs based on new issues found by newer tools
c745a74
@TravisEz13
remove catch to prevent hiding errors
411edd1
@TravisEz13
Add start-nativeexecution as a common helper
0ecfc95
@TravisEz13
use start-nativeexecution wrapper to ignore exit code for now
f87655e 
delete issues file before running test
iSazonov
Ilya (iSazonov) reviewed Sep 24, 2018
View reviewed changes
Comment thread test/common/markdown/markdown.tests.ps1
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.

Import-Module HelpersCommon

@iSazonov Ilya (iSazonov) Sep 24, 2018

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autoloading should works.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Sep 24, 2018
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 8a0abf4 into PowerShell:master Sep 24, 2018
@TravisEz13
Travis Plunk (TravisEz13) deleted the update_markdown_tests branch September 24, 2018 17:14
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Sep 25, 2018
@TravisEz13 Travis Plunk (TravisEz13) added the WG-Quality-Test issues in a test or in test infrastructure label Sep 25, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
update markdown tests (PowerShell#7838)
fd58a7f 
update markdown tests

  - explicitly use gulp 4.0 beta because 3.9 depends on a vulnerable package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
+2 more reviewers
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

WG-Quality-Test issues in a test or in test infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@TravisEz13 @daxian-dbw @rjmholt @anmenaga @adityapatwardhan @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.