GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Test changes needed for running in a container by JamesWTruher · Pull Request #7869 · PowerShell/PowerShell

Conversation

James Truher (JamesWTruher) commented Sep 26, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

PR Summary

These are changes which will enable our tests to be run within containers for the 9 different Linux platforms that we provide. In order to successfully run in a container an environment variable __InContainer must be present to avoid running the help test which starts a browser. The best place to define this variable is in the Dockerfile, ala:
ENV __InContainer 1

Additionally, these tests may be executed against the already installed PowerShell.

This is the first step in completely automating our tests against packaged (rather than built) PowerShell.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
User-facing changes
- Not Applicable
- OR
- User-facing Documentation needed
  - Issue filed - Issue link:
Testing - New and feature
- Not Applicable or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
  - Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

James Truher (JamesWTruher) assigned Aditya Patwardhan (adityapatwardhan)

Sep 26, 2018

James Truher (JamesWTruher) requested review from Travis Plunk (TravisEz13) and Aditya Patwardhan (adityapatwardhan)

September 26, 2018 17:17

Aditya Patwardhan (adityapatwardhan) requested changes

Sep 26, 2018

View reviewed changes

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1 Outdated

Aditya Patwardhan (adityapatwardhan) Sep 26, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo raher -> rather

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1 Outdated

Aditya Patwardhan (adityapatwardhan) Sep 26, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Where-Object instead

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1 Outdated

Aditya Patwardhan (adityapatwardhan) Sep 26, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo InternNetworkV6 -> InterNetworkV6

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1 Outdated

Aditya Patwardhan (adityapatwardhan) Sep 26, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ForEach-Object instead

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1 Outdated

Aditya Patwardhan (adityapatwardhan) Sep 26, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in -> if

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1 Outdated

Aditya Patwardhan (adityapatwardhan) Sep 26, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double check if this still needs to be maked as Pending. It worked on my Ubuntu 18.04 VM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

James Truher (JamesWTruher) Sep 27, 2018

Copy link

Copy Markdown

Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's definitely failing on my mac, I'll mark it pending for $IsMacOS

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1 Outdated

Aditya Patwardhan (adityapatwardhan) Sep 26, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1 Outdated

Aditya Patwardhan (adityapatwardhan) Sep 26, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this comment?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Aditya Patwardhan (adityapatwardhan) Sep 27, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove comment if it does not hang in VSTS.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/engine/Help/HelpSystem.OnlineHelp.Tests.ps1 Outdated

Aditya Patwardhan (adityapatwardhan) Sep 26, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this defined?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Aditya Patwardhan (adityapatwardhan) Sep 27, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment about $env:__InContainer

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Steve Lee (SteveL-MSFT) Sep 27, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code to open help in a browser is pretty simple. Perhaps rather than skipping these tests in non-desktop environments, we should instead have a test hook to validate that it hit the right code path or even start a test executable passed the URL as an argument?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

James Truher (JamesWTruher) Sep 27, 2018

Copy link

Copy Markdown

Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a test hook here already, and it is used to validate all the uris. This is a single test which starts the browser.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Steve Lee (SteveL-MSFT) Sep 27, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this for now

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Aditya Patwardhan (adityapatwardhan) requested changes

Sep 27, 2018

View reviewed changes

Comment thread

test/powershell/engine/Help/HelpSystem.OnlineHelp.Tests.ps1 Outdated

Aditya Patwardhan (adityapatwardhan) Sep 27, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment about $env:__InContainer

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1 Outdated

Aditya Patwardhan (adityapatwardhan) Sep 27, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove comment if it does not hang in VSTS.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Aditya Patwardhan (adityapatwardhan) commented Sep 27, 2018

Copy link

Copy Markdown

Member

James Truher (@JamesWTruher) Please also have a look at the test failure in CI for Linux and MacOS.

Also please push a commit with [Feature] to run all tests.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Test changes needed for running in a container

17ebbf5

James Truher (JamesWTruher) force-pushed the containertestfixes branch from c6b7e71 to 2efd9bd Compare

September 27, 2018 18:21

Aditya Patwardhan (adityapatwardhan) commented Sep 27, 2018

Copy link

Copy Markdown

Member

James Truher (@JamesWTruher) Test-Connection test is failing on Linux and macOS with Exception calling "GetHostEntry" with "1" argument(s): "No such device or address"

Also please push a commit with [Feature]

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Steve Lee (SteveL-MSFT) requested changes

Sep 27, 2018

View reviewed changes

Comment thread

test/powershell/engine/Help/HelpSystem.OnlineHelp.Tests.ps1 Outdated

Steve Lee (SteveL-MSFT) Sep 27, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

James Truher (JamesWTruher) force-pushed the containertestfixes branch from 2efd9bd to b670ede Compare

September 27, 2018 22:37

James Truher (JamesWTruher) commented Sep 27, 2018

Copy link

Copy Markdown

Collaborator Author

Steve Lee (@SteveL-MSFT) please see my comment above re: starting a browser

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Steve Lee (SteveL-MSFT) approved these changes

Sep 27, 2018

View reviewed changes


          [feature] Fix a number of typos

c7d0f7a

make the `MTUSizeDetect` tests pending for MacOS only.

James Truher (JamesWTruher) force-pushed the containertestfixes branch from b670ede to c7d0f7a Compare

September 28, 2018 17:07

Aditya Patwardhan (adityapatwardhan) approved these changes

Sep 28, 2018

View reviewed changes

Aditya Patwardhan (adityapatwardhan) merged commit 98cf44c into PowerShell:master

Sep 28, 2018

James Truher (JamesWTruher) deleted the containertestfixes branch

September 23, 2023 05:34

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Test changes needed for running in a container (PowerShell#7869)

9ecf4e9

Reviewers

Ilya (iSazonov)

iSazonov left review comments

Steve Lee (SteveL-MSFT)

SteveL-MSFT approved these changes

Aditya Patwardhan (adityapatwardhan)

adityapatwardhan approved these changes

Travis Plunk (TravisEz13)

Awaiting requested review from TravisEz13

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

James Truher (JamesWTruher) commented Sep 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Sep 27, 2018

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Sep 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

James Truher (JamesWTruher) commented Sep 27, 2018

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

James Truher (JamesWTruher) commented Sep 26, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.