GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Optimize Images! by RDIL · Pull Request #7874 · PowerShell/PowerShell

Conversation

Reece Dunham (RDIL) commented Sep 26, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

PR Summary

My pal Imgbot (@ImgBotApp) optimized all the images present in the repository.

PR Checklist

[PR has a meaningful title]
[Summarized changes]
[Change is not breaking]
[Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header]
This PR is ready to merge and is not [Work in Progress]
Testing - New and feature
- Can be tested right away

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Imgbot (ImgBotApp) and others added 2 commits

September 26, 2018 21:50


          [ImgBot] optimizes images

2fc7cc8

*Total -- 1,173.92kb -> 884.45kb (24.66%)

/.github/Images/GitHub-PR.png -- 13.15kb -> 7.83kb (40.44%)
/docs/testing-guidelines/Images/CoverageReportTop.PNG -- 440.22kb -> 325.20kb (26.13%)
/docs/testing-guidelines/Images/CoverageReportFilter.PNG -- 593.63kb -> 446.84kb (24.73%)
/docs/maintainers/Images/squash-merge.png -- 38.18kb -> 31.10kb (18.55%)
/docs/maintainers/Images/merge-commit.png -- 37.32kb -> 30.40kb (18.53%)
/docs/maintainers/Images/merge-commit-confirm.png -- 22.17kb -> 18.16kb (18.1%)
/docs/maintainers/Images/squash-confirm.png -- 24.58kb -> 20.26kb (17.54%)
/test/powershell/Modules/Microsoft.PowerShell.Security/TestData/CatalogTestData/TestImage.gif -- 4.68kb -> 4.66kb (0.6%)


          Merge pull request #1 from RDIL/imgbot

87ebb15

[ImgBot] optimize images

Reece Dunham (RDIL) requested review from Travis Plunk (TravisEz13) and Joey Aiello (joeyaiello) as code owners

September 26, 2018 21:57

Microsoft Contribution License Agreements (msftclas) commented Sep 26, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All CLA requirements met.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reece Dunham (RDIL) commented Sep 26, 2018

Copy link

Copy Markdown

Contributor Author

why did PowerShell-CI-linux — #PR-7874-20180926.01 fail :(

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reece Dunham (RDIL) commented Sep 26, 2018

Copy link

Copy Markdown

Contributor Author

Wait that's not my code thats failing

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ilya (iSazonov) assigned Travis Plunk (TravisEz13)

Sep 27, 2018

Ilya (iSazonov) commented Sep 27, 2018

Copy link

Copy Markdown

Collaborator

Reece Dunham (@RDIL) Please rebase to get latest commits and pass CIs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge pull request #2 from PowerShell/master

d379a30

Add 'TimeToLive' and 'Hops' aliases to MaxHops parameter of Test-Conn…

Reece Dunham (RDIL) commented Sep 27, 2018

Copy link

Copy Markdown

Contributor Author

I think I did it...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reece Dunham (RDIL) commented Sep 27, 2018

Copy link

Copy Markdown

Contributor Author

That’s odd, some checks are still failing :(

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reece Dunham (RDIL) commented Sep 27, 2018

Copy link

Copy Markdown

Contributor Author

Test failures:
Description: NewFileCatalogForFilesThatDoNotSupportEmbeddedSignatures
4037Name: Test suite for NewFileCatalogAndTestFileCatalogCmdlets.NewAndTestCatalogTests PositiveTestCases when validation Succeeds.NewFileCatalogForFilesThatDoNotSupportEmbeddedSignatures
4038message:
4039Expected strings to be the same, but they were different.
4040String lengths are both 40.
4041Strings differ at index 0.
4042Expected: {B0E4B9F0BB21284AA0AF0D525C913420AD73DA6A}
4043But was: {C1FCC65488C1DFF7F0D7C5F85F3091433AF09BBF}
4044-----------^
4045stack-trace:
4046at , C:\projects\powershell\test\powershell\Modules\Microsoft.PowerShell.Security\FileCatalog.Tests.ps1: line 30
404730: $keyValue1 | Should -Be $keyValue2
40481 tests in test/powershell failed
4049if ($env:Purpose -eq 'ElevatedPesterTests_xUnit_Packaging'){ Invoke-AppveyorFinish }

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ilya (iSazonov) commented Sep 27, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

Reece Dunham (@RDIL) Please revert the file test/powershell/Modules/Microsoft.PowerShell.Security/TestData/CatalogTestData/TestImage.gif

It is used in our tests.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reece Dunham (RDIL) added 3 commits

September 27, 2018 20:22


          Remove needed file


          Add back old TestImage.gif

7f06519

As requested by iSazonov.


          Merge pull request #3 from PowerShell/master

538a26c

Add new commits

Reece Dunham (RDIL) commented Sep 28, 2018

Copy link

Copy Markdown

Contributor Author

Ilya (@iSazonov) done!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge new commits from PowerShell/master

c485364

Merge newer commits from main powershell repo

Reece Dunham (RDIL) commented Sep 29, 2018

Copy link

Copy Markdown

Contributor Author

...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) approved these changes

Oct 1, 2018

View reviewed changes

Travis Plunk (TravisEz13) merged commit bc4575f into PowerShell:master

Oct 1, 2018

Ilya (iSazonov) commented Oct 2, 2018

Copy link

Copy Markdown

Collaborator

Reece Dunham (@RDIL) Thanks for your contribution!

TravisEz13 and RDIL reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reece Dunham (RDIL) commented Oct 2, 2018 via email

Copy link

Copy Markdown

Contributor Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Optimize Images! (PowerShell#7874)

8cda6df

My pal @ImgBotApp optimized all the images present in the repository.

Reviewers

Travis Plunk (TravisEz13)

TravisEz13 approved these changes

Joey Aiello (joeyaiello)

Awaiting requested review from joeyaiello

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Reece Dunham (RDIL) commented Sep 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Microsoft Contribution License Agreements (msftclas) commented Sep 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reece Dunham (RDIL) commented Sep 26, 2018

Uh oh!

Reece Dunham (RDIL) commented Sep 26, 2018

Uh oh!

Ilya (iSazonov) commented Sep 27, 2018

Uh oh!

Reece Dunham (RDIL) commented Sep 27, 2018

Uh oh!

Reece Dunham (RDIL) commented Sep 27, 2018

Uh oh!

Reece Dunham (RDIL) commented Sep 27, 2018

Uh oh!

Ilya (iSazonov) commented Sep 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reece Dunham (RDIL) commented Sep 28, 2018

Uh oh!

Reece Dunham (RDIL) commented Sep 29, 2018

Uh oh!

Ilya (iSazonov) commented Oct 2, 2018

Uh oh!

Reece Dunham (RDIL) commented Oct 2, 2018 via email

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Reece Dunham (RDIL) commented Sep 26, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Microsoft Contribution License Agreements (msftclas) commented Sep 26, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Ilya (iSazonov) commented Sep 27, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.