GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Cleanup all native code from repository by adityapatwardhan · Pull Request #7892 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Sep 28, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Native code for PowerShell has been moved to repository PowerShell/PowerShell-Native.

Hence, removing all the native code and related build components.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Travis Plunk (TravisEz13) September 28, 2018 22:51
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners September 28, 2018 22:51
iSazonov
Ilya (iSazonov) reviewed Sep 29, 2018
View reviewed changes
Comment thread src/PowerShell.Core.Instrumentation/README.md Outdated

@iSazonov Ilya (iSazonov) Sep 29, 2018

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to see a guidelines about new workflow for dev/debug and release. (Scenario - "I need use new Unix syscall")

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Oct 2, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened an issue in the powershell-native repro to track this.

PowerShell/PowerShell-Native#11

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
TravisEz13
Travis Plunk (TravisEz13) approved these changes Oct 1, 2018
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Oct 1, 2018

Copy link
Copy Markdown
Member

The wIndows build is failing with

2018-09-28T22:57:47.5130286Z C:\Users\VssAdministrator\Appdata\Local\Microsoft\dotnet\sdk\2.1.402\Microsoft.Common.CurrentVersion.targets(4533,5): error MSB3030: Could not copy the file "D:\a\1\s\src\PowerShell.Core.Instrumentation\PowerShell.Core.Instrumentation.man" because it was not found. [D:\a\1\s\src\powershell-win-core\powershell-win-core.csproj]
2018-09-28T22:57:47.5130819Z C:\Users\VssAdministrator\Appdata\Local\Microsoft\dotnet\sdk\2.1.402\Microsoft.Common.CurrentVersion.targets(4533,5): error MSB3030: Could not copy the file "D:\a\1\s\src\powershell-native\Install-PowerShellRemoting.ps1" because it was not found. [D:\a\1\s\src\powershell-win-core\powershell-win-core.csproj]
2018-09-28T22:57:47.5131507Z C:\Users\VssAdministrator\Appdata\Local\Microsoft\dotnet\sdk\2.1.402\Microsoft.Common.CurrentVersion.targets(4533,5): error MSB3030: Could not copy the file "D:\a\1\s\src\PowerShell.Core.Instrumentation\RegisterManifest.ps1" because it was not found. [D:\a\1\s\src\powershell-win-core\powershell-win-core.csproj]
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) force-pushed the CleanupBuild branch from bdee9b8 to 411844b Compare October 2, 2018 17:17
Aditya Patwardhan (adityapatwardhan) added 2 commits October 2, 2018 11:18
@adityapatwardhan
[Feature] Cleanup all native code from repository
c3a4854
@adityapatwardhan
[Feature] Donot remove files needed to be packaged
bae3ae1
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) force-pushed the CleanupBuild branch from 411844b to bae3ae1 Compare October 2, 2018 18:19
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Oct 2, 2018

Copy link
Copy Markdown
Member Author

Travis Plunk (@TravisEz13) Issues fixed. Can you have another look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) merged commit b42c001 into PowerShell:master Oct 2, 2018
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the CleanupBuild branch October 2, 2018 19:55
@iSazonov Ilya (iSazonov) mentioned this pull request Oct 4, 2018
Remove requirement for full VS install to build #1940
Closed
7 tasks
@andyleejordan Andy Jordan (andyleejordan) mentioned this pull request Nov 2, 2018
Remove build and doc references to Git submodules #8177
Merged
7 of 11 tasks
Andy Jordan (andyleejordan) added a commit to andyleejordan/PowerShell that referenced this pull request Nov 2, 2018
@andyleejordan
Remove build and doc references to Git submodules
62d7b36 
As of PowerShell#7892, the PowerShell repository no longer uses Git submodules.
This is fantastic from a workflow standpoint, and so all the notes about
how to deal with submodules (and all the build steps explicitly
initializing and updating submodules) can be safely removed.
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Nov 5, 2018
@andyleejordan @TravisEz13
Remove build and doc references to Git submodules (#8177)
5487418 
As of #7892, the PowerShell repository no longer uses Git submodules.
This is fantastic from a workflow standpoint, and so all the notes about
how to deal with submodules (and all the build steps explicitly
initializing and updating submodules) can be safely removed.
Aditya Patwardhan (adityapatwardhan) added a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019
@adityapatwardhan @TravisEz13
Cleanup all native code from repository (PowerShell#7892)
1e4843c 
Native code for PowerShell has been moved to repository PowerShell/PowerShell-Native.

Hence, removing all the native code and related build components.
@xtqqczze xtqqczze mentioned this pull request Jan 24, 2020
Update .editorconfig #11675
Merged
8 of 14 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan @TravisEz13
Cleanup all native code from repository (PowerShell#7892)
0156e3a 
Native code for PowerShell has been moved to repository PowerShell/PowerShell-Native.

Hence, removing all the native code and related build components.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@andyleejordan @TravisEz13
Remove build and doc references to Git submodules (PowerShell#8177)
ff7f2b8 
As of PowerShell#7892, the PowerShell repository no longer uses Git submodules.
This is fantastic from a workflow standpoint, and so all the notes about
how to deal with submodules (and all the build steps explicitly
initializing and updating submodules) can be safely removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@adityapatwardhan @TravisEz13 @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.