GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update installpsh amazonlinux for container build by DarwinJS · Pull Request #7907 · PowerShell/PowerShell

Conversation

@DarwinJS

@DarwinJS Darwin (DarwinJS) commented Oct 1, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Fix #7906 - add packages tar and gzip so that install will work on amazon linux 2 container image which has minimal packages
Fix #7903 - change "if" to "fi"

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Darwin (DarwinJS) added 2 commits October 1, 2018 04:25
@DarwinJS
fix syntax error for issue 7903
651cb93
@DarwinJS
add tar and gzip packages
a44c3ca
@DarwinJS
Darwin (DarwinJS) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners October 1, 2018 09:01
@iSazonov

Ilya (iSazonov) commented Oct 1, 2018

Copy link
Copy Markdown
Collaborator

Darwin (@DarwinJS) Please rebase to get latest commit and add more information in description.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Oct 1, 2018
TravisEz13
Travis Plunk (TravisEz13) approved these changes Oct 1, 2018
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Oct 1, 2018

Copy link
Copy Markdown
Member

Darwin (@DarwinJS) Did you look at the CodeFactor issues?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Darwin (DarwinJS) added 2 commits October 2, 2018 05:58
@DarwinJS
add tar and gzip packages
35dcd5c
@DarwinJS
Merge branch 'update-installpsh-amazonlinux-for-container-build' of h…
508af92 
…ttps://github.com/DarwinJS/PowerShell into update-installpsh-amazonlinux-for-container-build
@DarwinJS

Darwin (DarwinJS) commented Oct 2, 2018

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) - I did look at the issues - seems like a lot of refactoring to cleanup long standing syntax. I would like to just get this small update worked in without touching that much code if that is ok?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Oct 2, 2018

Copy link
Copy Markdown
Member

Manikyam Bavandla (@bmanikm) Can you review? Failures are unrelated to Darwin (@DarwinJS)'s changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bmanikm
Manikyam Bavandla (bmanikm) approved these changes Oct 2, 2018
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Oct 2, 2018

Copy link
Copy Markdown
Member

I restarted all CI's
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anmenaga Andrew (anmenaga) assigned Aditya Patwardhan (adityapatwardhan) Oct 23, 2018
@anmenaga

Andrew (anmenaga) commented Oct 23, 2018

Copy link
Copy Markdown

Travis Plunk (@TravisEz13) Aditya Patwardhan (@adityapatwardhan) This looks ready for merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Oct 24, 2018
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit ddaad12 into PowerShell:master Oct 24, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@DarwinJS @adityapatwardhan
Update installpsh amazonlinux for container build (PowerShell#7907)
f8ecb09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@bmanikm Manikyam Bavandla (bmanikm) bmanikm approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update installpsh-amazonlinux.sh to run on Amazon Linux 2 container build Syntax error in installpsh-amazonlinux.sh

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@DarwinJS @iSazonov @TravisEz13 @anmenaga @bmanikm @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.