GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove clone args by iSazonov · Pull Request #7910 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Oct 1, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Close #7457.

The cleanup is needed after #7449 and #2538.

  • args is never null
  • We never change the args array and exclude cloning.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov Ilya (iSazonov) added the Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality label Oct 1, 2018
@iSazonov
Ilya (iSazonov) requested review from Paul Higinbotham (PaulHigin) and Travis Plunk (TravisEz13) October 1, 2018 13:24
@iSazonov
Ilya (iSazonov) requested review from Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners October 1, 2018 13:24
@TravisEz13

Travis Plunk (TravisEz13) commented Oct 1, 2018

Copy link
Copy Markdown
Member

Dongbo Wang (@daxian-dbw) Not sure why this was there in the first place.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anmenaga
Andrew (anmenaga) suggested changes Oct 10, 2018
View reviewed changes

@anmenaga Andrew (anmenaga) left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to get a [feature] test pass on this. Thanks.

Also, Dongbo Wang (@daxian-dbw) any ideas regarding Travis's question? I wonder the same thing as well...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
TravisEz13
Travis Plunk (TravisEz13) reviewed Oct 10, 2018
View reviewed changes
Comment thread src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs Outdated

@TravisEz13 Travis Plunk (TravisEz13) Oct 10, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably leave the null check in the code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Oct 11, 2018

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is c# convention that args is never null?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Ilya (iSazonov) added 3 commits October 12, 2018 08:57
@iSazonov
Remove dumb code
28b3ff1 
- args is never null
- the code is not used
@iSazonov
Remove unneeded args cloning
ae7154f
@iSazonov
[Feature]
d0d0300
@iSazonov
Ilya (iSazonov) force-pushed the remove-clone-args branch from 61de45f to d0d0300 Compare October 12, 2018 03:58
anmenaga
Andrew (anmenaga) approved these changes Oct 25, 2018
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Oct 26, 2018

Copy link
Copy Markdown
Collaborator Author

Dongbo Wang (@daxian-dbw) Can you confirm that we can merge?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) merged commit c36e4ad into PowerShell:master Oct 29, 2018
@iSazonov
Ilya (iSazonov) deleted the remove-clone-args branch October 30, 2018 03:03
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov @TravisEz13
Cleanup: Remove clone of command-line args array (PowerShell#7910)
43aeb78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 left review comments
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cleanup args clone

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iSazonov @TravisEz13 @anmenaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.