GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Specify verb for context menu to avoid overriding the default verb by bergmeister · Pull Request #7932 · PowerShell/PowerShell

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Oct 3, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

  • Fixes Context Menu\Folder shortcut problem after installing PS Core 6.1 on Windows #7815
  • Fixes Windows "previous versions" now opens pwsh.exe not explorer #6799

Fix is to specify the verb (pwsh) for the context menu, otherwise there can be special cases (see issues) where it overrides the default verb, see comment here for details. Thanks to Ji Luo (@GeeLaw) for the helpful comments.

I will manually check in the next days that the installer will remove the old open entries during upgrade.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
specify verb for context menu to avoid overriding the default verb
255f779
@iSazonov

Ilya (iSazonov) commented Oct 3, 2018

Copy link
Copy Markdown
Collaborator

If we update current "broken" installation with the new installer what will happen to the old "open" key? I'd expect that we remove it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov
Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Travis Plunk (TravisEz13) October 3, 2018 09:46
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Oct 3, 2018
@bergmeister

Christoph Bergmeister (bergmeister) commented Oct 3, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

During an upgrade, old components get removed, therefore the old registry keys 'should' get removed.
As mentioned in the description, I will manually test this by creating a 6.1.0, 6.1.1 and 6.2.0 installer and go through the upgrade scenarios to be sure since WiX/MSI is known to have unintuitive behaviour.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Oct 3, 2018

Copy link
Copy Markdown
Member

Christoph Bergmeister (@bergmeister) the change looks fine, but will wait for your testing results
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister

Christoph Bergmeister (bergmeister) commented Oct 3, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Steve Lee (@SteveL-MSFT) Ilya (@iSazonov)
I manually created installers for 6.1.0, 6.1.1 and 6.2.0 and can confirm that the old open registry keys get replaced with the openpwsh keys upon upgrade from 6.1.0 to 6.1.1 and from 6.1.0 to 6.2.0 and the keys also get removed on uninstall.
I created the MSIs as follows:

Import-Module .\build.psm1; Start-PSBuild -Clean -CrossGen -PSModuleRestore -Runtime win7-x64 -Configuration Release; Import-Module .\tools\packaging
Start-PSPackage -Type msi -WindowsRuntime 'win7-x64' -SkipReleaseChecks -Version 6.1.0 # from master
Start-PSPackage -Type msi -WindowsRuntime 'win7-x64' -SkipReleaseChecks -Version 6.1.1 # from PR branch
Start-PSPackage -Type msi -WindowsRuntime 'win7-x64' -SkipReleaseChecks -Version 6.2.0 # from PR branch
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Oct 3, 2018
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 49826a7 into PowerShell:master Oct 4, 2018
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Oct 12, 2018
Windows Previous Versions 'Open' of previous version of folder causes open of PowerShell at that location and point in time. #8007
Closed
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Nov 17, 2018
PowerShell-6.2.0-preview.2-win-x64 creates duplicate "Open here" context menu item (also preview.3) #8290
Closed
Aditya Patwardhan (adityapatwardhan) pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019
@bergmeister @TravisEz13
Specify verb, pwsh, for shell context menu to avoid overriding the …
2fd323b 
…default verb (PowerShell#7932)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@bergmeister @TravisEz13
Specify verb, pwsh, for shell context menu to avoid overriding the …
4af23fc 
…default verb (PowerShell#7932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Context Menu\Folder shortcut problem after installing PS Core 6.1 on Windows Windows "previous versions" now opens pwsh.exe not explorer

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bergmeister @iSazonov @SteveL-MSFT @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.