GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Standardize syntax in 'ReplaceOperator.Tests.ps1' by sethvs · Pull Request #7963 · PowerShell/PowerShell

Conversation

@sethvs

@sethvs Sergey Vasin (sethvs) commented Oct 7, 2018

Copy link
Copy Markdown
Contributor

PR Summary

  • Change BeExactly parameter to -BeExactly
  • Change $_[0] to $_ in the Replace operator can take a ScriptBlock in place of a substitution string test since it is scalar System.Text.RegularExpressions.Match object and not an array.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Sergey Vasin (sethvs) added 2 commits October 7, 2018 17:07
@sethvs
Fix 'ReplaceOperator.Tests.ps1'
3ef8f77
@sethvs
Update 'Markdig.Signed'
57f3126
@sethvs
Sergey Vasin (sethvs) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners October 7, 2018 14:40
iSazonov
Ilya (iSazonov) approved these changes Oct 8, 2018
View reviewed changes
@iSazonov Ilya (iSazonov) assigned Aditya Patwardhan (adityapatwardhan) Oct 8, 2018
TravisEz13
Travis Plunk (TravisEz13) approved these changes Oct 8, 2018
View reviewed changes
@TravisEz13 Travis Plunk (TravisEz13) changed the title Fix 'ReplaceOperator.Tests.ps1' Standardize syntax in 'ReplaceOperator.Tests.ps1' Oct 8, 2018
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 3b31608 into PowerShell:master Oct 9, 2018
Aditya Patwardhan (adityapatwardhan) pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019
@sethvs @daxian-dbw
Standardize Pester syntax in 'ReplaceOperator.Tests.ps1' (PowerShell#…
9c4c4fe
…7963)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@sethvs @daxian-dbw
Standardize Pester syntax in 'ReplaceOperator.Tests.ps1' (PowerShell#…
5a79d98
…7963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sethvs @TravisEz13 @iSazonov @daxian-dbw @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.