GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Removing aliases usages in build.psm1 by kvprasoon · Pull Request #7964 · PowerShell/PowerShell

Conversation

@kvprasoon

@kvprasoon PRASOON KARUNAN V (kvprasoon) commented Oct 7, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Converting aliases to cmdlets in build.psm1

PR Summary

Converting aliases to cmdlets in build.psm1

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kvprasoon
Converting aliases to cmdlets in build.psm1
bf274c7 
Converting aliases to cmdlets in build.psm1
@kvprasoon
PRASOON KARUNAN V (kvprasoon) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners October 7, 2018 16:30
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Oct 7, 2018
View reviewed changes
@bergmeister

Christoph Bergmeister (bergmeister) commented Oct 7, 2018

Copy link
Copy Markdown
Contributor

LGTM but not sure if the named parameters usage is a bit over the top
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Oct 8, 2018
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Oct 8, 2018

Copy link
Copy Markdown
Collaborator

PRASOON KARUNAN V (@kvprasoon) Please rebase to pass CIs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister

Christoph Bergmeister (bergmeister) commented Oct 8, 2018

Copy link
Copy Markdown
Contributor

Ilya (@iSazonov) Just re-queuing the build or making an empty commit should do the trick as well since PR builds are run in a PR branch, which is the forked branch as if it was already merged into master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Oct 8, 2018
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 112b485 into PowerShell:master Oct 9, 2018
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and Dongbo Wang (daxian-dbw) and unassigned Ilya (iSazonov) Oct 9, 2018
Aditya Patwardhan (adityapatwardhan) pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019
@kvprasoon @daxian-dbw
Converting aliases to cmdlets in 'build.psm1' (PowerShell#7964)
96462f2
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@kvprasoon @daxian-dbw
Converting aliases to cmdlets in 'build.psm1' (PowerShell#7964)
6004758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@kvprasoon @bergmeister @iSazonov @TravisEz13 @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.