GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update README.md by VMCpp · Pull Request #7978 · PowerShell/PowerShell

Conversation

@VMCpp

@VMCpp VMCpp commented Oct 9, 2018 •
edited by iSazonov
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Simple grammatical correction in README.md file.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@VMCpp
Update README.md
3ad48d7
SteveL-MSFT
Steve Lee (SteveL-MSFT) previously requested changes Oct 9, 2018
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this PR provides much value. The current content is fine.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anmenaga

Andrew (anmenaga) commented Oct 10, 2018

Copy link
Copy Markdown

Steve Lee (@SteveL-MSFT) I actually think that PR provides more value than what is listed in the 'Files changes'. Something we discussed previously.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
Steve Lee (SteveL-MSFT) dismissed their stale review October 10, 2018 21:55

Deferring to Andrew to review

@RDIL

Reece Dunham (RDIL) commented Oct 10, 2018

Copy link
Copy Markdown
Contributor

I think this is the only one that makes more sense:

  • If you already cloned but forgot to use --recursive, you can update submodules manually:
  • If you have already cloned but forgot to use --recursive, you can update submodules manually:
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anmenaga
Andrew (anmenaga) approved these changes Oct 11, 2018
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) approved these changes Oct 19, 2018
View reviewed changes
Comment thread README.md
@@ -194,7 +194,7 @@ To make things easy, you can just clone recursively:
git clone --recursive https://github.com/PowerShell/PowerShell.git

@TravisEz13 Travis Plunk (TravisEz13) Oct 19, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--recursive is not needed anymore.

Do you want to fix this or merge as is?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Oct 29, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like this to be removed as --recursive is not needed anymore.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anmenaga Andrew (anmenaga) assigned Aditya Patwardhan (adityapatwardhan) Oct 26, 2018
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Oct 29, 2018

Copy link
Copy Markdown
Member

IgoTenz Please fill the PR template above, it helps us create change logs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and Aditya Patwardhan (adityapatwardhan) and unassigned Aditya Patwardhan (adityapatwardhan) and Ilya (iSazonov) Nov 1, 2018
@iSazonov

Ilya (iSazonov) commented Nov 1, 2018

Copy link
Copy Markdown
Collaborator

Aditya Patwardhan (@adityapatwardhan) I updated the PR description.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) merged commit c5c747c into PowerShell:master Nov 1, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@VMCpp @TravisEz13
Simple grammatical correction in README.md file (PowerShell#7978)
380306b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan left review comments
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT left review comments
+1 more reviewer
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@VMCpp @anmenaga @RDIL @adityapatwardhan @iSazonov @TravisEz13 @SteveL-MSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.