GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve error message on non-Windows when importing clixml with securestring by SteveL-MSFT · Pull Request #7997 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Oct 11, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Currently, if you try to import clixml that contains a securestring, you get this error:

Import-Clixml : Unable to load shared library 'CRYPT32.dll' or one of its dependencies.

This dll is only available on Windows and causes confusion why it's not working. Change is to throw PlatformNotSupportedException on non-Windows.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jazzdelightsme reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested review from Paul Higinbotham (PaulHigin) and Travis Plunk (TravisEz13) October 11, 2018 17:58
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Travis Plunk (TravisEz13) Oct 11, 2018
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the deserialize-securestring-error branch 2 times, most recently from 250a304 to 0718f77 Compare October 11, 2018 21:08
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Oct 11, 2018
View reviewed changes
Comment thread src/System.Management.Automation/resources/Serialization.resx Outdated

@PaulHigin Paul Higinbotham (PaulHigin) Oct 11, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Deserialization of SecureString is currently only supported on Windows." ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SteveL-MSFT reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Steve Lee (SteveL-MSFT) added 2 commits October 11, 2018 15:55
@SteveL-MSFT
improve error message on non-Windows when importing clixml with secur…
05ebbbf 
…estring
@SteveL-MSFT
address Paul's feedback
e0b5d1d
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the deserialize-securestring-error branch from cbb8ef4 to e0b5d1d Compare October 11, 2018 22:55
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Oct 11, 2018
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) approved these changes Oct 12, 2018
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit b62e152 into PowerShell:master Oct 12, 2018
Aditya Patwardhan (adityapatwardhan) pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019
@SteveL-MSFT @TravisEz13
Improve error message on non-Windows when importing clixml with secur…
9e84974 
…estring (PowerShell#7997)
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the deserialize-securestring-error branch March 10, 2020 21:01
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @TravisEz13
Improve error message on non-Windows when importing clixml with secur…
2e35b42 
…estring (PowerShell#7997)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
+1 more reviewer
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@SteveL-MSFT @daxian-dbw @TravisEz13 @PaulHigin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.