GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove PDBs from fxdependent package by adityapatwardhan · Pull Request #8006 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Oct 12, 2018 •
edited by TravisEz13
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Remove PDBs from fxdependent package to reduce size.
Also fix daily builds by adding NoPSModuleRestore flag when build with -Symbols

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan
Remove PDBs from fxdependent pacakge
2099afd
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Travis Plunk (TravisEz13) October 12, 2018 00:22
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners October 12, 2018 00:22
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title Remove PDBs from fxdependent pacakge Remove PDBs from fxdependent package Oct 12, 2018
TravisEz13
Travis Plunk (TravisEz13) approved these changes Oct 12, 2018
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 5fcab21 into PowerShell:master Oct 12, 2018
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the RemoveSymsFromFxD branch October 12, 2018 22:04
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 14, 2019
Aditya Patwardhan (adityapatwardhan) added a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019
@adityapatwardhan @TravisEz13
Remove PDBs from fxdependent pacakge (PowerShell#8006)
f883bd1
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request May 14, 2019
@adityapatwardhan @TravisEz13
Remove PDBs from fxdependent pacakge (PowerShell#8006)
9457a9b 
# Conflicts:
#	tools/packaging/packaging.psm1
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan @TravisEz13
Remove PDBs from fxdependent pacakge (PowerShell#8006)
9c1bf83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@adityapatwardhan @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.