GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Linux ARM64 build support by slide · Pull Request #8016 · PowerShell/PowerShell

Conversation

@slide

@slide Alex Earl (slide) commented Oct 12, 2018

Copy link
Copy Markdown
Contributor

PR Summary

This adds an additional flag to allow building for linux-arm64.

PR Checklist

  • [PR has a meaningful title]
  • [Summarized changes]
  • [Change is not breaking]
  • [Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header]
  • This PR is ready to merge and is not [Work in Progress]
  • User-facing changes
    • Not Applicable
  • Testing - New and feature
    • Not Applicable or can only be tested interactively

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jeremymcgee73 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@slide
Alex Earl (slide) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners October 12, 2018 23:12
@slide Alex Earl (slide) mentioned this pull request Oct 12, 2018
Request for PowerShell for ARM64 Ubuntu #7330
Closed
@slide

Alex Earl (slide) commented Oct 12, 2018

Copy link
Copy Markdown
Contributor Author

Related to #7330
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) added WG-Maintainers-Build specific to affecting the build Documentation Needed in this repo Documentation is needed in this repo labels Oct 12, 2018
@TravisEz13

Travis Plunk (TravisEz13) commented Oct 12, 2018

Copy link
Copy Markdown
Member

Alex Earl (@slide) Did you do any testing of the build?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Oct 12, 2018

Copy link
Copy Markdown
Member

Is ARM64 also Raspbian? Should we update this doc to say both architectures of Raspbian?
https://docs.microsoft.com/en-us/powershell/scripting/powershell-core-support?view=powershell-6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Oct 12, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

You also need to do some work if you want us to release a package (you could just file an issue for this, if that wasn't your intent.)

The packaging module needs to be updated to be able to package TarArm64

PowerShell/tools/packaging/packaging.psm1

Line 68 in 81b67c9

} elseif ($Type -eq "tar-arm") {

PowerShell/tools/releaseBuild/Images/GenericLinuxFiles/PowerShellPackage.ps1

Line 57 in 81b67c9

if ($TarArm) {

Needs to be updated with a TarArm64 option

And it needs to be called here:

PowerShell/tools/releaseBuild/build.json

Line 264 in 81b67c9

"BuildCommand": "/PowerShellPackage.ps1 -location _RepoDestinationPath_ -destination _DockerVolume_ -ReleaseTag _ReleaseTag_ -TarX64 -TarArm",

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slide

Alex Earl (slide) commented Oct 13, 2018

Copy link
Copy Markdown
Contributor Author

Yes, I tested on my RockPro64 board. I was using it to build ironpython on that board. I will also update the packaging, I was looking for that and didn't know where it was.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slide

Alex Earl (slide) commented Oct 13, 2018

Copy link
Copy Markdown
Contributor Author

My board is running Ubuntu 18.04 Bionic, not Raspian.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slide

Alex Earl (slide) commented Oct 13, 2018

Copy link
Copy Markdown
Contributor Author

How do I run the packaging stuff locally to test it out?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Oct 13, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

run start-psbuild -configuration 'release' -crossgen -psmodulerestore
then import the packaging module Import-module .\tools\packaging -force
then run packaging start-pspackaging -Type tar-arm64

I did this from memory and start-pspackaging might tell you, that you need to skip release checks... It's fine to do that for development.

If you only change the packaging code, you can just re-import the packaging module, and rerun the packaging step (this is why I separated the modules.)
PixleProgrambetaxl reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joeyaiello Joey Aiello (joeyaiello) mentioned this pull request Oct 15, 2018
Docs needed for 'Add Linux ARM64 build support' MicrosoftDocs/PowerShell-Docs#3016
Closed
@joeyaiello Joey Aiello (joeyaiello) removed Documentation Needed in this repo Documentation is needed in this repo labels Oct 15, 2018
@iSazonov

Ilya (iSazonov) commented Nov 1, 2018

Copy link
Copy Markdown
Collaborator

Alex Earl (@slide) What is status of the PR? Do you want to continue?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slide

Alex Earl (slide) commented Nov 1, 2018

Copy link
Copy Markdown
Contributor Author

Yes, I do, I just need to get back to it again. I'll try and do it this next week.
iSazonov and TravisEz13 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slide
Alex Earl (slide) requested a review from Paul Higinbotham (PaulHigin) as a code owner November 8, 2018 12:12
@TravisEz13

Travis Plunk (TravisEz13) commented Nov 13, 2018

Copy link
Copy Markdown
Member

restarted linux CI due to a connectivity issue
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slide

Alex Earl (slide) commented Nov 13, 2018

Copy link
Copy Markdown
Contributor Author

I do still plan on getting back to this, if it needs to be closed for now for some reason, I can reopen at a later date if desired.
SteveL-MSFT, TravisEz13, and jeremymcgee73 reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slide

Alex Earl (slide) commented Dec 3, 2018

Copy link
Copy Markdown
Contributor Author

I will not have time to get back to this for some time. Trying to get a local build of the package stuff has not been easy.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slide Alex Earl (slide) closed this Dec 3, 2018
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Dec 4, 2018

Copy link
Copy Markdown
Member

Alex Earl (@slide) Thanks for starting this, I'll submit a new PR with the packaging work along with the changes you've made for the build
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT Steve Lee (SteveL-MSFT) reopened this Dec 4, 2018
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Dec 4, 2018

Copy link
Copy Markdown
Member

I'll just re-use this PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slide
Alex Earl (slide) requested review from Bruce Payette (BrucePay) and Francisco Gamino (Francisco-Gamino) as code owners December 4, 2018 04:17
@slide
Alex Earl (slide) requested review from James Truher (JamesWTruher), Joey Aiello (joeyaiello) and Mike Richmond (mirichmo) as code owners December 4, 2018 04:17
@slide @SteveL-MSFT
Add arm64 build for Linux
491d6d4
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Aditya Patwardhan (adityapatwardhan) Dec 4, 2018
@SteveL-MSFT
Steve Lee (SteveL-MSFT) removed request for Bruce Payette (BrucePay), Francisco Gamino (Francisco-Gamino), James Truher (JamesWTruher), Paul Higinbotham (PaulHigin), Joey Aiello (joeyaiello) and Mike Richmond (mirichmo) December 4, 2018 04:25
@SteveL-MSFT Steve Lee (SteveL-MSFT) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Dec 4, 2018
@SteveL-MSFT
[package]
d22bd92 
update packaging to support tar-arm64
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Dec 4, 2018

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) - You need to add items suggest by comment #8016 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
[package]
5c05b80 
address Travis' feedback
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Dec 4, 2018

Copy link
Copy Markdown
Member

Aditya Patwardhan (@adityapatwardhan) latest commit should address the rest of Travis Plunk (@TravisEz13) 's feedback
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Dec 4, 2018
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 74de391 into PowerShell:master Dec 5, 2018
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Dec 5, 2018

Copy link
Copy Markdown
Member

Alex Earl (@slide) Thank you for your contribution!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@slide @adityapatwardhan
Add Linux ARM64 build support (PowerShell#8016)
90ff3cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log WG-Maintainers-Build specific to affecting the build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@slide @TravisEz13 @iSazonov @SteveL-MSFT @adityapatwardhan @joeyaiello
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.