GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||
GeezerVison is showing github.com — Add a path for checking ZoneInformation without throwing an exception by powercode · Pull Request #8025 · PowerShell/PowerShell Conversation
|
| string errorMessage = StringUtil.Format( | ||
| FileSystemProviderStrings.AlternateDataStreamNotFound, streamName, path); | ||
| throw new FileNotFoundException(errorMessage, resultPath); | ||
| throw new FileNotFoundException(errorMessage, $"{path}:{streamName.Trim()}"); |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Do we really need Trim() for streamName in the internal methods? We do not this for path.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Not sure - I just opted to not change any functionality. Small cost on the error path.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I vote to remove - I believe consumer should take care.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.