GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make S.M.A.PowerShell.GetSteppablePipeline method public by KirkMunro · Pull Request #8055 · PowerShell/PowerShell

Conversation

@KirkMunro

@KirkMunro Kirk Munro (KirkMunro) commented Oct 17, 2018

Copy link
Copy Markdown
Contributor

PR Summary

PowerShell advanced function authors can create proxy functions in native PowerShell, but PowerShell cmdlet authors cannot create proxy cmdlets in native .NET. The S.M.A.PowerShell.GetSteppablePipeline() method is marked as internal, yet it is useful in both PowerShell and .NET when you want to work with proxy commands. This PR is simply to change the visibility of the GetSteppablePipeline method to public so that binary cmdlet authors don't need to use reflection to get access to this essential method.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link: GetSteppablePipeline method documentation needed MicrosoftDocs/PowerShell-Docs#3128
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jazzdelightsme and briantist reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@KirkMunro
make GetSteppablePipeline method public
482ac75
@KirkMunro
Kirk Munro (KirkMunro) requested review from Bruce Payette (BrucePay) and Dongbo Wang (daxian-dbw) as code owners October 17, 2018 01:00
@KirkMunro

Kirk Munro (KirkMunro) commented Oct 17, 2018

Copy link
Copy Markdown
Contributor Author

Similar to the other PR I submitted earlier, I did not include test fixtures for this PR because I was not sure it needed any. If you want some added, please indicate where (Pester, or in a C# unit test). Thank you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Oct 17, 2018
Kirk Munro (KirkMunro) added 2 commits November 4, 2018 17:22
@KirkMunro
Merge branch 'master' into make-getsteppablepipeline-public
e978e85
@KirkMunro
updated PowerShell member count
56ea31e
@KirkMunro

Kirk Munro (KirkMunro) commented Nov 5, 2018

Copy link
Copy Markdown
Contributor Author

Note: after this PR or #8056 are approved/merged, the other will have to be updated with the latest code and the Pester test that tests tab expansion and counts members on S.M.A.PowerShell will have to be updated (the count will increase by one). Just adding this comment so that I remember to update whichever of these isn't merged once the other one is so that there are no merge conflicts and all tests pass.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Nov 28, 2018

Copy link
Copy Markdown
Member

@PowerShell/powershell-committee reviewed this and is ok making this public
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT Steve Lee (SteveL-MSFT) added Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Nov 28, 2018
@stale

stale Bot commented Dec 29, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot added the Stale label Dec 29, 2018
@KirkMunro

Kirk Munro (KirkMunro) commented Jan 3, 2019

Copy link
Copy Markdown
Contributor Author

This is not stale, it's just awaiting merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot removed the Stale label Jan 3, 2019
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Travis Plunk (TravisEz13) Jan 9, 2019
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Jan 9, 2019
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Travis Plunk (TravisEz13) merged commit 1729a68 into PowerShell:master Jan 9, 2019
@TravisEz13 Travis Plunk (TravisEz13) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Jan 9, 2019
@KirkMunro
Kirk Munro (KirkMunro) deleted the make-getsteppablepipeline-public branch January 10, 2019 18:19
@sdwheeler Sean Wheeler (sdwheeler) modified the milestone: 6.2.0 Mar 25, 2019
@TravisEz13 Travis Plunk (TravisEz13) added this to the 6.3.0-preview.1 milestone Mar 29, 2019
@joeyaiello Joey Aiello (joeyaiello) mentioned this pull request Jan 10, 2020
Document GetSteppablePipeline #11553
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@KirkMunro @TravisEz13
Make S.M.A.PowerShell.GetSteppablePipeline method public (PowerShell#…
a835fcb 
…8055)

* make GetSteppablePipeline method public
* updated PowerShell member count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Milestone

7.0.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@KirkMunro @SteveL-MSFT @TravisEz13 @sdwheeler @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.