GeezerVison is showing github.com — Fix `-psmodulerestore` path when `start-psbuild` is used in VSCode default build task by SteveL-MSFT · Pull Request #8075 · PowerShell/PowerShell
Conversation
PR Summary
The logic in set the publish path for -psmodulerestore assumes a path that contains the pwsh executable so it uses the parent of -OutputPath. However, the VSCode default build task specifies a debug folder in the root of the repo. So the logic uses the parent and thus creates a Modules folder in the root of the repo. The fix is to check if the -OutputPath ends with pwsh and if so use the previous logic of using the parent folder, otherwise, just use the -OutputPath.
PR Checklist
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.