GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Added updated photo of VScode due to new version of VScode by lassehastrup · Pull Request #8084 · PowerShell/PowerShell

Conversation

@Lasse (lassehastrup) commented Oct 19, 2018

Copy link

Copy Markdown

Contributor

PR Summary

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
User-facing changes
- Not Applicable
- OR
- User-facing Documentation needed
  - Issue filed - Issue link:
Testing - New and feature
- Not Applicable or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
  - Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@Lasse (lassehastrup) added 4 commits

October 19, 2018 13:56


          Add files via upload

b9f4413


          Delete VSCode.png

373e256


          Delete VScode.PNG

2980eb9


          Added updated vscode.png

a7327fb

Ilya (iSazonov) assigned Travis Plunk (TravisEz13)

Oct 19, 2018

Andrew (anmenaga) suggested changes

Oct 22, 2018

View reviewed changes

Andrew (anmenaga) left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New photo was taken on a high-res screen, so when auto-scaled to the low-width boundaries of 'using-vscode.md' tutorial it will be unreadable.
For taking the screenshot please: 1) temporary drop the resolution of the screen 2) make sure that VS code window is relatively square (currently proposed image is twice as wide as it is tall).

PS. While you are at it, it would be great if you could double-check 'Editing with Visual Studio Code' instructions on 'using-vscode.md'. Are they still accurate on the latest VS Code version? Thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@Lasse (lassehastrup) added 8 commits

October 23, 2018 10:23


          Delete vscode.png

2dc4023


          Added non-highresolution vscode.png

6e71be2


          Delete VScode.PNG

a47dd5f


          Add files via upload

c056245


          Deleted highresolution vscode.png

d6a8098


          Replaced highresulution vscode.png

3e202d5


          Delete vscode.PNG

aab9588


          Replaced highresolution vscode.png

1b4a2db

@Lasse (lassehastrup) commented Oct 23, 2018 via email

Copy link

Copy Markdown

Contributor Author

Hi Andrew, Thank you for your feedback. I have replaced the photo, which make the scaling better. It’s currently 1920x1080, which is more “square”. And by using the Preview function, I can see it fits the window. Also, I went through the ‘using-vscode.md’, and I can confirm that it is still updated and relevant. Best regards, Lasse Hastrup Fra: Andrew <[email protected]> Sendt: Monday, October 22, 2018 10:37 PM Til: PowerShell/PowerShell <[email protected]> Cc: Lasse Hastrup <[email protected]>; Author <[email protected]> Emne: Re: [PowerShell/PowerShell] Added updated photo of VScode due to new version of VScode (#8084) @anmenaga requested changes on this pull request. New photo was taken on a high-res screen, so when auto-scaled to the low-width boundaries of 'using-vscode.md' tutorial it will be unreadable. For taking the screenshot please: 1) temporary drop the resolution of the screen 2) make sure that VS code window is relatively square (currently proposed image is twice as wide as it is tall). PS. While you are at it, it would be great if you could double-check 'Editing with Visual Studio Code' instructions on 'using-vscode.md'. Are they still accurate on the latest VS Code version? Thanks. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#8084 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Ap--SN1OLxmrzrw12w85wBSWlME3wRU9ks5uniyIgaJpZM4XwOwb>.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Andrew (anmenaga) approved these changes

Oct 23, 2018

View reviewed changes

Travis Plunk (TravisEz13) merged commit 7076d80 into PowerShell:master

Oct 29, 2018

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Added updated photo of VScode due to new version of VScode (PowerShel…

59fbdda

…l#8084)

Reviewers

1 more reviewer

Andrew (anmenaga)

anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.