GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Remove notes about `ITuple` changes(#7633) from v6.2.0-preview.1 updates. by stknohg · Pull Request #8101 · PowerShell/PowerShell

Conversation

Takuya Shibata (stknohg) commented Oct 22, 2018

Copy link

Copy Markdown

Contributor

PR Summary

Related #8070, #8077.

The notes of #7633 was already included in PowerShell Core 6.1.0 stable.

Note: We also must update Release notes of v6.2.0-preview.1.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
User-facing changes
- Not Applicable
- OR
- User-facing Documentation needed
  - Issue filed - Issue link:
Testing - New and feature
- Not Applicable or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
  - Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Remove #7633 from v6.2.0-preview.1 updates.

9efb832

Andrew (anmenaga) reviewed

Oct 22, 2018

View reviewed changes

Andrew (anmenaga) left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing change log is probably too late.
But we can manually update description of the v6.2.0-preview.1 release.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Ilya (iSazonov) commented Oct 23, 2018

Copy link

Copy Markdown

Collaborator

The update is useful for next release.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ilya (iSazonov) approved these changes

Oct 23, 2018

View reviewed changes

Ilya (iSazonov) closed this

Oct 23, 2018

Ilya (iSazonov) reopened this

Oct 23, 2018

Ilya (iSazonov) commented Oct 23, 2018

Copy link

Copy Markdown

Collaborator

Reopen PR to restart CIs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Takuya Shibata (stknohg) commented Nov 2, 2018

Copy link

Copy Markdown

Contributor Author

Currently, WIP is required.
Do I need to do something?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ilya (iSazonov) commented Nov 2, 2018

Copy link

Copy Markdown

Collaborator

Steve Lee (@SteveL-MSFT) Travis Plunk (@TravisEz13) Can we fix the change log issue?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Steve Lee (SteveL-MSFT) assigned Travis Plunk (TravisEz13)

Nov 2, 2018

Steve Lee (SteveL-MSFT) commented Nov 2, 2018

Copy link

Copy Markdown

Member

If the changelog is wrong, we should fix it. We can ignore the WIP bot since it's clear it doesn't apply to this PR.

iSazonov reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ilya (iSazonov) commented Nov 2, 2018

Copy link

Copy Markdown

Collaborator

Travis Plunk (@TravisEz13) Please merge the PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) merged commit 03ba61c into PowerShell:master

Nov 5, 2018

Takuya Shibata (stknohg) deleted the fix-8070 branch

November 12, 2018 06:49

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Remove PowerShell#7633 from v6.2.0-preview.1 Changlog updates. (Power…

5a75e4c

…Shell#8101)

Reviewers

Ilya (iSazonov)

iSazonov approved these changes

+1 more reviewer

Andrew (anmenaga)

anmenaga left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.