GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — Enable experimental feature to support tab completion on abbreviated cmdlets by SteveL-MSFT · Pull Request #8109 · PowerShell/PowerShell Conversation
|
|
This needs another |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
b95ae6d to
d7721be
Compare
|
Dongbo Wang (@daxian-dbw) Bruce Payette (@BrucePay) This PR needs your review. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
d7721be to
af7ea4e
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
there's nothing in my comments which are blocking, but I am worried about the case where we have an error (CompletionCompleters, line 193)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
24c1d29 to
f130bd9
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
68d927c to
0893d7c
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
248961b to
9138e21
Compare
There was an error while loading. Please reload this page.
|
Steve Lee (@SteveL-MSFT) There is one comment pending #8109 (comment), can you please respond to it? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
fixed code to support returning multiple results and not just first one added test for automoduleloading which also covers multiple results from different modules
9138e21 to
dc7739e
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Dongbo Wang (@daxian-dbw) Do we add experimental features to Change log? Do we need set |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Re-add wildcard when searching AST + Missed test case. ## PR Context In #8109, we removed the line that added a wildcard to the end of the command that was used to match commands in the script AST. This readds that line closer to where it is used.
Re-add wildcard when searching AST + Missed test case. ## PR Context In #8109, we removed the line that added a wildcard to the end of the command that was used to match commands in the script AST. This readds that line closer to where it is used.
…tab completion on abbreviated command names (PowerShell#8109)
…#9383) Re-add wildcard when searching AST + Missed test case. ## PR Context In PowerShell#8109, we removed the line that added a wildcard to the end of the command that was used to match commands in the script AST. This readds that line closer to where it is used.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.