GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Filter the TestPackage artifact upload by name to avoid other zip files being uploaded by adityapatwardhan · Pull Request #8116 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Oct 24, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Added logging for New-TestPackage to make debugging easier.
Filter the artifact uploads with the package name instead of *.zip to avoid Help Zip files from being uploaded.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Aditya Patwardhan (adityapatwardhan) added 2 commits October 24, 2018 15:36
@adityapatwardhan
Debug macOS test package
964b64f
@adityapatwardhan
Filter test artifact by name
d12496e
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from James Truher (JamesWTruher) October 24, 2018 23:53
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners October 24, 2018 23:53
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Oct 24, 2018

Copy link
Copy Markdown
Member Author

I have verified the changes on a private CI run, which is a clone of the official Azure DevOps pipeline.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anmenaga
Andrew (anmenaga) approved these changes Oct 25, 2018
View reviewed changes

@anmenaga Andrew (anmenaga) left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 update needed; otherwise looks good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .vsts-ci/mac.yml Outdated
# Uploads any packages as an artifact
- powershell: |
Get-ChildItem -Path *.pkg, *.tar.gz, *.zip -Recurse | Select-Object -ExpandProperty FullName | ForEach-Object {
Write-Host "PWD == $pwd"

@anmenaga Andrew (anmenaga) Oct 25, 2018

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember $pwd variable should Not be used in scripts. Change to Get-Location.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JamesWTruher reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@JamesWTruher James Truher (JamesWTruher) Oct 25, 2018

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's likely in this context it's ok, but something that we should be aware of.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JamesWTruher
James Truher (JamesWTruher) approved these changes Oct 25, 2018
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comment isn't blocking

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .vsts-ci/mac.yml Outdated
# Uploads any packages as an artifact
- powershell: |
Get-ChildItem -Path *.pkg, *.tar.gz, *.zip -Recurse | Select-Object -ExpandProperty FullName | ForEach-Object {
Write-Host "PWD == $pwd"

@JamesWTruher James Truher (JamesWTruher) Oct 25, 2018

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's likely in this context it's ok, but something that we should be aware of.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov Ilya (iSazonov) assigned Aditya Patwardhan (adityapatwardhan) Oct 26, 2018
@adityapatwardhan
Remove debug message
677910f
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Oct 29, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

James Truher (@JamesWTruher) Andrew (@anmenaga) Removed the usage of $pwd it was a debug statement which can now be removed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Oct 29, 2018

Copy link
Copy Markdown
Member Author

I will merge when CI passes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit d7c7fa5 into PowerShell:master Oct 29, 2018
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the FixMacOSTestPackage branch October 29, 2018 21:13
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Filter the TestPackage artifact upload by name to avoid other zip fil…
c9221d5 
…es being uploaded (PowerShell#8116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
2 more reviewers
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@adityapatwardhan @JamesWTruher @anmenaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.