GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Enable case-insensitive tab completion for files and folders on case-sensitive filesystem by SteveL-MSFT · Pull Request #8128 · PowerShell/PowerShell

Conversation

Steve Lee (SteveL-MSFT) commented Oct 26, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

PR Summary

Leverage new EnumerationOption in .NET Core 2.1 to have case-insensitive enumeration of files and folders. Allows for case-insensitive tab completion of files and folders on a case-sensitive filesystem.

#1273

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
User-facing changes
- Not Applicable
- OR
- User-facing Documentation needed
  - Issue filed - Issue link:
Testing - New and feature
- Not Applicable or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
  - Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          enable case-insensitive tab completion for files and folders

3b7e328

Steve Lee (SteveL-MSFT) assigned Ilya (iSazonov)

Oct 26, 2018

Steve Lee (SteveL-MSFT) requested review from Dongbo Wang (daxian-dbw) and Ilya (iSazonov)

October 26, 2018 04:43

Steve Lee (SteveL-MSFT) requested review from Bruce Payette (BrucePay) and Andrew (anmenaga) as code owners

October 26, 2018 04:43


          sort the completions before validation as the order isn't guaranteed

97e83dd

Steve Lee (SteveL-MSFT) force-pushed the case-insensitive-completion branch from ce88cb6 to c59c3f9 Compare

October 26, 2018 17:21


          [feature]

5db5590

need to explicitly have enumoptions not skip hidden/system files to retain existing behavior

Steve Lee (SteveL-MSFT) force-pushed the case-insensitive-completion branch from c59c3f9 to 5db5590 Compare

October 26, 2018 17:25

Ilya (iSazonov) reviewed

Oct 26, 2018

View reviewed changes

Ilya (iSazonov) left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/System.Management.Automation/namespaces/FileSystemProvider.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Outdated

		}

		It "Test case insensitive folder path" -Skip:(!$IsLinux) {
		$testDirs = "AA", "Aa", "aa"

Ilya (iSazonov) Oct 26, 2018

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could check dirs in previous test with files.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

SteveL-MSFT reacted with thumbs up emoji

All reactions

👍 1 reaction


          address Ilya's feedback

07b18e4

Steve Lee (SteveL-MSFT) force-pushed the case-insensitive-completion branch from 8c4c313 to 07b18e4 Compare

October 26, 2018 20:01

Ilya (iSazonov) approved these changes

Oct 26, 2018

View reviewed changes

Comment thread

src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.


          added comment for AttributesToSkip and added test mixing files and fo…

a5b5889

…lders

Steve Lee (SteveL-MSFT) force-pushed the case-insensitive-completion branch from 7377e03 to a5b5889 Compare

October 26, 2018 20:39

Ilya (iSazonov) reviewed

Oct 27, 2018

View reviewed changes

Comment thread

src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1

9d75e2f

Co-Authored-By: SteveL-MSFT <[email protected]>

Ilya (iSazonov) approved these changes

Oct 28, 2018

View reviewed changes

Ilya (iSazonov) merged commit b27380d into PowerShell:master

Oct 28, 2018

Ilya (iSazonov) commented Oct 28, 2018

Copy link

Copy Markdown

Collaborator

Steve Lee (@SteveL-MSFT) Should we close #1273?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Steve Lee (SteveL-MSFT) deleted the case-insensitive-completion branch

October 28, 2018 06:17

Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label

Jan 17, 2019

Dongbo Wang (daxian-dbw) mentioned this pull request

Jan 7, 2020

tab-completion PowerShell/PSReadLine#1283

Closed

Ilya (iSazonov) mentioned this pull request

Dec 16, 2020

Feature Request: An option to enable case-sensitive tab completion. #14337

Closed

surfingoldelephant mentioned this pull request

Jan 1, 2026

about_Case-Sensitivity lacks detail in a lot of areas MicrosoftDocs/PowerShell-Docs#12624

Closed

3 tasks done

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Enable case-insensitive tab completion for files and folders on case-…

78f3885

…sensitive filesystem (PowerShell#8128)

Reviewers

Ilya (iSazonov)

iSazonov approved these changes

Dongbo Wang (daxian-dbw)

Awaiting requested review from daxian-dbw

Andrew (anmenaga)

Awaiting requested review from anmenaga

Bruce Payette (BrucePay)

Awaiting requested review from BrucePay

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Ilya (iSazonov)

Labels

CL-General

Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Steve Lee (SteveL-MSFT) commented Oct 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Ilya (iSazonov) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ilya (iSazonov) Oct 26, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ilya (iSazonov) commented Oct 28, 2018

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Steve Lee (SteveL-MSFT) commented Oct 26, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.