GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add test coverage for additional Get-Module parameters by KevinMarquette · Pull Request #8137 · PowerShell/PowerShell

Conversation

@KevinMarquette

@KevinMarquette Kevin Marquette (KevinMarquette) commented Oct 28, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

add test coverage for Get-Module parameters FullyQualifiedName ,PSEdition and Refresh

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • [-] User-facing Documentation needed
      • [-] Issue filed - Issue link:
  • Testing - New and feature
    • [-] Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • [-] Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@KevinMarquette Kevin Marquette (KevinMarquette) changed the title add test coverage for additional Get-Module parameters [WIP] add test coverage for additional Get-Module parameters Oct 28, 2018
@KevinMarquette
add test coverage for Get-Module
529264c
@KevinMarquette
Kevin Marquette (KevinMarquette) force-pushed the kevinmarquette/get-module-test-coverage branch from 0712608 to 529264c Compare October 28, 2018 21:05
@KevinMarquette Kevin Marquette (KevinMarquette) changed the title [WIP] add test coverage for additional Get-Module parameters add test coverage for additional Get-Module parameters Oct 28, 2018
@iSazonov
Ilya (iSazonov) requested review from Aditya Patwardhan (adityapatwardhan) and Rob Holt (rjmholt) October 30, 2018 05:32
rjmholt
Rob Holt (rjmholt) approved these changes Oct 30, 2018
View reviewed changes

@rjmholt Rob Holt (rjmholt) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like important coverage to me!

One thing that strikes me is the name of the file (which I know is pre-existing). The tests here all cover Get-Module -ListAvailable scenarios, where Get-Module scenarios are mostly covered in ModuleConstraint.Tests.ps1 and the CompatiblePSEditions checks are covered in CompatiblePSEditions.Tests.ps1 (different to the ones here, they don't filter by PSEdition explicitly but do the implicity manifest check for modules on the Windows PowerShell module path).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rjmholt
Rob Holt (rjmholt) requested a review from Dongbo Wang (daxian-dbw) October 30, 2018 06:10
@iSazonov

Ilya (iSazonov) commented Nov 1, 2018

Copy link
Copy Markdown
Collaborator

Kevin Marquette (@KevinMarquette) Please address Rob Holt (@rjmholt) feedback about file names.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rjmholt

Rob Holt (rjmholt) commented Nov 1, 2018

Copy link
Copy Markdown
Collaborator

Oh sorry, my feedback isn't terribly clear.

I would support changing the file name to something like Get-Module-ListAvailable.Tests.ps1 (theoretically, maybe it should be ListAvailable.Get-Module.Tests.ps1...?). Point is that Get-Module is tested in a whole bunch of places, and discoverability is a problem for our tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Nov 2, 2018

Copy link
Copy Markdown
Collaborator

Aditya Patwardhan (@adityapatwardhan) We need your help.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Nov 2, 2018
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Get-Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Get-Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Nov 2, 2018

Copy link
Copy Markdown
Member

For the organization of test cases to make them discoverable, I think it's out of scope for this PR and should be a separate PR.
iSazonov, vexx32, and rjmholt reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KevinMarquette
Create new context for PSEdition tests
27fdb7b
@KevinMarquette
Kevin Marquette (KevinMarquette) force-pushed the kevinmarquette/get-module-test-coverage branch from 7f7add8 to 27fdb7b Compare November 3, 2018 18:50
@KevinMarquette
whitespace
9e2ad33
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Nov 3, 2018
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iSazonov
Ilya (iSazonov) reviewed Nov 4, 2018
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Get-Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Get-Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Get-Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Get-Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Kevin Marquette
test style corrections
eadd2a4
@iSazonov Ilya (iSazonov) self-assigned this Nov 7, 2018
@iSazonov
Ilya (iSazonov) merged commit 75fa6af into PowerShell:master Nov 7, 2018
@iSazonov

Ilya (iSazonov) commented Nov 7, 2018

Copy link
Copy Markdown
Collaborator

Kevin Marquette (@KevinMarquette) Thanks for your contribution!
KevinMarquette reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KevinMarquette
Kevin Marquette (KevinMarquette) deleted the kevinmarquette/get-module-test-coverage branch November 8, 2018 05:13
@iSazonov Ilya (iSazonov) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 17, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@KevinMarquette @iSazonov
Add test coverage for additional Get-Module parameters (PowerShell#8137)
d3487d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@KevinMarquette @iSazonov @rjmholt @SteveL-MSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.