GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Adding verbose output for experimental implicit remoting batching feature by PaulHigin · Pull Request #8166 · PowerShell/PowerShell

Conversation

@PaulHigin

@PaulHigin Paul Higinbotham (PaulHigin) commented Nov 1, 2018

Copy link
Copy Markdown
Contributor

PR Summary

This change adds verbose output to the experimental implicit remoting batching feature, that provides information about whether the command line was batch-able for implicit remoting. If it is not batch-able then the reason why is provided. This is intended to help learn why a pipeline could not be batched and help address batching scenarios that should be covered.

Example:

$s = New-PSSession -host testVM -KeyFilePath -User paul
Invoke-Command $s { Import-PSSession 'c:\Modules\TestIMod\TestIMod.psd1' }
Import-PSSession $s -module TestIMod

$maxProcs = 1000
$filter = 'pwsh','powershell*'

$VerbosePreference = "Continue"

Get-AllProcesses -MaxCount $maxProcs | Select-Custom $filter | ForEach-Object { $_ }
VERBOSE: Implicit remoting command pipeline has been batched for execution on remote target.

NPM(K)    PM(M)      WS(M)     CPU(s)      Id  SI ProcessName
 ------    -----      -----     ------      --  -- -----------
     60   291.51     140.08     226.92   15184   2 powershell
     54   129.84     109.26     370.78   15832   2 powershell
     57    69.21      92.28      13.86     168   0 pwsh

100 | Get-AllProcesses -MaxCount $maxProcs | Select-Custom $filter | ForEach-Object { $_ }
VERBOSE: Command pipeline not supported for implicit remoting batching. : PipelineStartingWithExpressionNotSupported

NPM(K)    PM(M)      WS(M)     CPU(s)      Id  SI ProcessName
 ------    -----      -----     ------      --  -- -----------
     61   291.54     140.09     226.92   15184   2 powershell
     54   129.84     109.26     370.88   15832   2 powershell
     57    69.72      92.86      17.81     168   0 pwsh

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@PaulHigin
[Feature] Added verbose output for experimental implicit remoting bat…
da73704
…ching feature
@PaulHigin
Paul Higinbotham (PaulHigin) requested review from Bruce Payette (BrucePay) and Dongbo Wang (daxian-dbw) as code owners November 1, 2018 16:54
@PaulHigin Paul Higinbotham (PaulHigin) assigned Aditya Patwardhan (adityapatwardhan) Nov 1, 2018
@PaulHigin Paul Higinbotham (PaulHigin) added the Experimental Experimental Feature label Nov 1, 2018
@PaulHigin Paul Higinbotham (PaulHigin) added this to the 6.1.x-servicing milestone Nov 1, 2018
@PaulHigin Paul Higinbotham (PaulHigin) removed the Experimental Experimental Feature label Nov 1, 2018
@PaulHigin
[Feature] Fixed CodeFactor issues
7b2026a
@PaulHigin

Paul Higinbotham (PaulHigin) commented Nov 1, 2018

Copy link
Copy Markdown
Contributor Author

Steve Lee (@SteveL-MSFT) Can you review this change?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Nov 1, 2018
View reviewed changes
Comment thread src/System.Management.Automation/resources/ParserStrings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/resources/ParserStrings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/resources/ParserStrings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.

Paul Higinbotham (PaulHigin) added 2 commits November 1, 2018 11:32
@PaulHigin
Updated verbose messages per CR feedback.
6df5555
@PaulHigin
[Feature]
6a662e2
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Nov 1, 2018
View reviewed changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) removed this from the 6.1.x-servicing milestone Nov 1, 2018
iSazonov
Ilya (iSazonov) reviewed Nov 2, 2018
View reviewed changes
Comment thread src/System.Management.Automation/resources/ParserStrings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.

Paul Higinbotham (PaulHigin) added 3 commits November 2, 2018 08:22
@PaulHigin
Fixed verbose text per CR comment
74b7a64
@PaulHigin
Added code to merge error data stream to output for batched commands
94c9f3e
@PaulHigin
[Feature]
bd183c7
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 5, 2018

Copy link
Copy Markdown
Member

The CI seems to be stuck. I will close and re-open the PR for restarting it.

PaulHigin reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) closed this Nov 5, 2018
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) reopened this Nov 5, 2018
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Nov 5, 2018
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit acf5eb5 into PowerShell:master Nov 5, 2018
@PaulHigin
Paul Higinbotham (PaulHigin) deleted the UpdateImplicitRemotingBatching branch November 6, 2018 00:10
@iSazonov Ilya (iSazonov) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Jan 17, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@PaulHigin @adityapatwardhan
Adding verbose output for experimental implicit remoting batching fea…
502b09e
…ture (PowerShell#8166)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@PaulHigin @adityapatwardhan @SteveL-MSFT @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.