GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix conflict with `Get-AdlStoreChildItem` from `az` module in tab completions tests by TravisEz13 · Pull Request #8167 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Nov 1, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Fix conflict with Get-AdlStoreChildItem from az module in tab completions tests

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Fix conflict with Get-AdlStoreChildItem from az module in tab com…
18591ef 
…pletion tests
anmenaga
Andrew (anmenaga) approved these changes Nov 1, 2018
View reviewed changes

@anmenaga Andrew (anmenaga) left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aditya Patwardhan (@adityapatwardhan) We need to get this in asap; CI's for other PRs are failing without this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anmenaga Andrew (anmenaga) mentioned this pull request Nov 1, 2018
More promoting https #8165
Merged
6 of 8 tasks
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Nov 1, 2018
View reviewed changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) self-assigned this Nov 1, 2018
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit c6910a1 into PowerShell:master Nov 1, 2018
@TravisEz13
Travis Plunk (TravisEz13) deleted the fix_daily_test_failure branch November 1, 2018 19:49
Travis Plunk (TravisEz13) added a commit to TravisEz13/PowerShell that referenced this pull request Nov 7, 2018
@TravisEz13
Merged PR 5614: Fix conflict with Get-AdlStoreChildItem from az m…
b26805d 
…odule in tab completion tests (PowerShell#8167)

Fix conflict with `Get-AdlStoreChildItem` from `az` module in tab completion tests (PowerShell#8167)
@iSazonov Ilya (iSazonov) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 17, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13 @adityapatwardhan
Fix conflict with Get-AdlStoreChildItem from az module in tab com…
79a12e4 
…pletion tests (PowerShell#8167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
+1 more reviewer
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@TravisEz13 @anmenaga @adityapatwardhan @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.