GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Adding yml for Linux builds by anmenaga · Pull Request #8168 · PowerShell/PowerShell

Conversation

@anmenaga

@anmenaga Andrew (anmenaga) commented Nov 1, 2018

Copy link
Copy Markdown

PR Summary

As part of improving the build process, the UI build pipeline for Linux Builds was converted to a yml-based pipeline.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andrew Menagarishvili
Adding LinuxBuild.yml
b541a78
@anmenaga Andrew (anmenaga) added the WG-Maintainers-Build specific to affecting the build label Nov 1, 2018
@anmenaga Andrew (anmenaga) assigned Travis Plunk (TravisEz13) Nov 1, 2018
@anmenaga
Andrew (anmenaga) requested a review from Travis Plunk (TravisEz13) November 1, 2018 18:48
@anmenaga
Andrew (anmenaga) requested review from Paul Higinbotham (PaulHigin), Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners November 1, 2018 18:48
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Nov 1, 2018
View reviewed changes
Comment thread tools/releaseBuild/LinuxBuild.yml Outdated
}

Write-Verbose -Message "$vstsCommandString " -Verbose
Write-Host -Object "##$vstsCommandString"

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Nov 1, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@anmenaga Andrew (anmenaga) Nov 1, 2018

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andrew Menagarishvili
Fixed CodeFactor issues and formatting
1c033b0
TravisEz13
Travis Plunk (TravisEz13) approved these changes Nov 1, 2018
View reviewed changes

@TravisEz13 Travis Plunk (TravisEz13) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor issues.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tools/releaseBuild/LinuxBuild.yml Outdated
Write-Host -Object "##$vstsCommandString"
displayName: 'Skip FxDependent for PS v6.0.*'

- task: ShellScript@2

@TravisEz13 Travis Plunk (TravisEz13) Nov 1, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task shouldn't be needed anymore

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@anmenaga Andrew (anmenaga) Nov 1, 2018

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tools/releaseBuild/LinuxBuild.yml Outdated
clean: true
jobs:

- job: Job_1

@TravisEz13 Travis Plunk (TravisEz13) Nov 1, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give the job a meaningful name, like Build

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@anmenaga Andrew (anmenaga) Nov 1, 2018

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andrew Menagarishvili
PR feedback
c3ecb70
TravisEz13
Travis Plunk (TravisEz13) approved these changes Nov 1, 2018
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Nov 1, 2018

Copy link
Copy Markdown
Member

maybe move the file to a subfolder (in the same location as the file) called azureDevOps
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Andrew Menagarishvili
moved yml file to azureDevOps subfolder
bac8b90
@TravisEz13
Travis Plunk (TravisEz13) merged commit 3597d58 into PowerShell:master Nov 5, 2018
@iSazonov Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jan 17, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Andrew @TravisEz13
Adding yml for Linux builds (PowerShell#8168)
ccb9733 
As part of improving the build process, the UI build pipeline for Linux Builds was converted to a yml-based pipeline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log WG-Maintainers-Build specific to affecting the build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@anmenaga @TravisEz13 @adityapatwardhan @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.