GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Token calculation fix for Get-Help executed on ScriptBlock. by hubuk · Pull Request #8238 · PowerShell/PowerShell

Conversation

@hubuk

@hubuk Hubert Bukowski (hubuk) commented Nov 12, 2018 •
edited by adityapatwardhan
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix for #8234

PR Summary

Changed token calculation for Get-Help cmdlet.
Added test case for function dynamically created from script block.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@hubuk
Fixed token calculation for Get-Help executed on ScriptBlock.
c8541da
@hubuk
Hubert Bukowski (hubuk) requested review from Francisco Gamino (Francisco-Gamino) and Aditya Patwardhan (adityapatwardhan) as code owners November 12, 2018 18:33
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) self-assigned this Nov 12, 2018
@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 16, 2018
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Nov 19, 2018
View reviewed changes
@adityapatwardhan
[Feature]
8505361
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 19, 2018

Copy link
Copy Markdown
Member

Hubert Bukowski (@hubuk) I have pushed a commit with [Feature] tag according to https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr

The new test is part of a Describe which is marked as Feature. Hence, this was required.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hubuk

Hubert Bukowski (hubuk) commented Nov 20, 2018

Copy link
Copy Markdown
Contributor Author

Thanks, I can add [Feature] prefix to the message in my commit. Would you like me to do it instead and rebase my commit?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 20, 2018

Copy link
Copy Markdown
Member

Hubert Bukowski (@hubuk) Don't worry about rebasing. I pushed an empty commit with [Feature] and we usually squash and merge.

I have restarted the CI on AppVeyor to pick up the fixes for the unrelated failing test.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit a8627b8 into PowerShell:master Nov 20, 2018
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 20, 2018

Copy link
Copy Markdown
Member

Hubert Bukowski (@hubuk) Thank you for your contribution!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hubuk
Hubert Bukowski (hubuk) deleted the issue8234 branch November 20, 2018 23:21
Ilya (iSazonov) pushed a commit to iSazonov/PowerShell that referenced this pull request Nov 29, 2018
@hubuk @iSazonov
Token calculation fix for Get-Help executed on ScriptBlock for commen…
8001d70 
…t help. (PowerShell#8238)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@hubuk @adityapatwardhan
Token calculation fix for Get-Help executed on ScriptBlock for commen…
dedabbf 
…t help. (PowerShell#8238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@Francisco-Gamino Francisco Gamino (Francisco-Gamino) Awaiting requested review from Francisco-Gamino

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hubuk @adityapatwardhan @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.