GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add fix for Start-Job initialization script in system lockdown by PaulHigin · Pull Request #8284 · PowerShell/PowerShell

Conversation

@PaulHigin

@PaulHigin Paul Higinbotham (PaulHigin) commented Nov 15, 2018

Copy link
Copy Markdown
Contributor

PR Summary

This is a Windows platform issue only.

When running remote initialization script, the script block is considered internal and marked as trusted. In system lock down mode, PowerShell runs in ConstrainedLanguage mode and won't allow a trusted script block to run in the default scope.

Fix is to mark the initialization script as untrusted external when system is locked down.

Repro:

# PowerShell running in locked down system
Start-Job -InitializationScript { function Hello { "Hello" } } -ScriptBlock { Hello } | Wait-Job | Receive-Job

# Result
Error: "Cannot dot-source this command because it was defined in a different language mode. To invoke this command without importing its contents, omit the '.' operator."

Fix is to mark initialization script as untrusted "external origin" when system is in lock down mode, so that it can run in ConstrainedLanguage session scope.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@PaulHigin
Add fix for Start-Job initialization script in system lockdown
aebe0d0
@PaulHigin
Paul Higinbotham (PaulHigin) requested a review from Travis Plunk (TravisEz13) November 15, 2018 23:49
@PaulHigin
Paul Higinbotham (PaulHigin) requested a review from Mike Richmond (mirichmo) as a code owner November 15, 2018 23:49
@PaulHigin
Paul Higinbotham (PaulHigin) removed the request for review from Mike Richmond (mirichmo) November 15, 2018 23:49
@PaulHigin Paul Higinbotham (PaulHigin) assigned Aditya Patwardhan (adityapatwardhan) Nov 15, 2018
@PaulHigin Paul Higinbotham (PaulHigin) added OS-Windows WG-Remoting PSRP issues with any transport layer labels Nov 15, 2018
@iSazonov Ilya (iSazonov) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Nov 16, 2018
@TravisEz13 Travis Plunk (TravisEz13) changed the title [Feature] Add fix for Start-Job initialization script in system lockdown Add fix for Start-Job initialization script in system lockdown Nov 16, 2018
TravisEz13
Travis Plunk (TravisEz13) approved these changes Nov 16, 2018
View reviewed changes
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Nov 19, 2018
View reviewed changes
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 19, 2018

Copy link
Copy Markdown
Member

Paul Higinbotham (@PaulHigin), could you push a commit with [Feature] tag in it. The new test that is added is tagged as Feature hence was not executed in the CI.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@PaulHigin
[Feature]
36b09d0
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 21, 2018

Copy link
Copy Markdown
Member

Restarted CI in appveyor to pickup the latest test fixes.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@PaulHigin

Paul Higinbotham (PaulHigin) commented Nov 26, 2018

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) Can this be merged?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 6a388f0 into PowerShell:master Nov 26, 2018
@PaulHigin
Paul Higinbotham (PaulHigin) deleted the fix_startjob_initScript branch November 27, 2018 17:50
Ilya (iSazonov) pushed a commit to iSazonov/PowerShell that referenced this pull request Nov 29, 2018
@PaulHigin @iSazonov
Add fix for Start-Job initialization script should not be executed …
e1c4713
…as trusted in system lockdown (PowerShell#8284)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@PaulHigin @adityapatwardhan
Add fix for Start-Job initialization script should not be executed …
5d5c8ba
…as trusted in system lockdown (PowerShell#8284)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log OS-Windows WG-Remoting PSRP issues with any transport layer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@PaulHigin @adityapatwardhan @TravisEz13 @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.