GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix for PSDrive creation with a UNC path with a trailing backslash or forward slash when combined with -Persist by kvprasoon · Pull Request #8305 · PowerShell/PowerShell

Conversation

@kvprasoon

@kvprasoon PRASOON KARUNAN V (kvprasoon) commented Nov 18, 2018 •
edited by iSazonov
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Close #8242

Fix for PSDrive creation with a UNC path with a trailing backslash or forward slash when combined with -Persist

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link: New-PSDrive fails with a UNC path with a trailing backslash when combined with -Persist #8242
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mklement0 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@kvprasoon
Fix for issue 8242
7f0c05c
@kvprasoon
PRASOON KARUNAN V (kvprasoon) requested review from Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners November 18, 2018 09:00
@kvprasoon
codefactor fix
1788e66
iSazonov
Ilya (iSazonov) reviewed Nov 18, 2018
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/Microsoft.PowerShell.Commands.Management/commands/management/Navigation.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kvprasoon
Changes as per review comments
2415fa9
@iSazonov

Ilya (iSazonov) commented Nov 20, 2018

Copy link
Copy Markdown
Collaborator

PRASOON KARUNAN V (@kvprasoon) Please make the PR title more meaningful and add tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kvprasoon PRASOON KARUNAN V (kvprasoon) changed the title Fix for issue 8242 Fix for PSDrive creation with a UNC path with a trailing backslash or forward slash when combined with -Persist Nov 20, 2018
PRASOON KARUNAN V (kvprasoon) added 2 commits November 21, 2018 00:34
@kvprasoon
added tests for PowerShell#8305
dbddef2
@kvprasoon
Correcting WindowsRequireAdmin to RequireAdminOnWindows
7155f5b
iSazonov
Ilya (iSazonov) reviewed Nov 21, 2018
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 21, 2018
PRASOON KARUNAN V (kvprasoon) added 3 commits November 22, 2018 01:15
@kvprasoon
Changes as per review comment
9977732
@kvprasoon
Changes as per review comments by adding a new line.
9cf4236
@kvprasoon
trigger ci again
29b5fed
iSazonov
Ilya (iSazonov) reviewed Nov 23, 2018
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kvprasoon
Adding New-PSDrive.tests as per review comments.
4c4159b
iSazonov
Ilya (iSazonov) reviewed Nov 24, 2018
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/New-PSDrive.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/New-PSDrive.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
PRASOON KARUNAN V (kvprasoon) added 2 commits November 25, 2018 10:07
@kvprasoon
removing typo and adding new line at EoF as per review comments.
e997466
@kvprasoon
Adding missed OS Check
3a5b481
iSazonov
Ilya (iSazonov) approved these changes Nov 25, 2018
View reviewed changes
@iSazonov
Ilya (iSazonov) requested a review from Steve Lee (SteveL-MSFT) November 25, 2018 13:14
@iSazonov Ilya (iSazonov) self-assigned this Nov 25, 2018
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Nov 27, 2018
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/New-PSDrive.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/New-PSDrive.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Nov 29, 2018

Copy link
Copy Markdown
Collaborator

PRASOON KARUNAN V (@kvprasoon) Please resolve merge conflicts and address comments.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
PRASOON KARUNAN V (kvprasoon) added 4 commits November 29, 2018 22:37
@kvprasoon
rearranged parameters and get unused drive names as per review comments
d47081f
@kvprasoon
Merging from Master
8998e80
@kvprasoon
Merging from master
795a750
@kvprasoon
Corrrecting Typo in Name parameter
b4c70aa
@kvprasoon

PRASOON KARUNAN V (kvprasoon) commented Nov 30, 2018

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Done 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Nov 30, 2018
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov
Ilya (iSazonov) merged commit 6e523f2 into PowerShell:master Nov 30, 2018
@iSazonov

Ilya (iSazonov) commented Nov 30, 2018

Copy link
Copy Markdown
Collaborator

PRASOON KARUNAN V (@kvprasoon) Thanks for your contribution!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kvprasoon
PRASOON KARUNAN V (kvprasoon) deleted the fix-8242 branch November 30, 2018 05:00
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@kvprasoon @iSazonov
Fix for PSDrive creation with a UNC path with a trailing backslash or…
f06e7e1 
… forward slash when combined with -Persist (PowerShell#8305)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New-PSDrive fails with a UNC path with a trailing backslash when combined with -Persist

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kvprasoon @iSazonov @SteveL-MSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.