GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Skip tests on Appveyor due to PSReadline issue by adityapatwardhan · Pull Request #8317 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Nov 20, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Enter-PSHostProcess tests fail on AppVeyor due to PSReadline issue. This change skips the tests on AppVeyor.

Expected 3948, but got @(<empty>, 'Oops, something went wrong.  Please report this bug with the details below.', 'Report on GitHub: https://github.com/lzybkr/PSReadLine/issues/new', '-----------------------------------------------------------------------', 'Last 0 Keys:', '```', <empty>, '```', <empty>, 'Exception:').

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@adityapatwardhan
[Feature] Skip tests on Appveyor due to PSReadline issue
d80f368
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Steve Lee (SteveL-MSFT) November 20, 2018 00:15
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title [Feature] Skip tests on Appveyor due to PSReadline issue Skip tests on Appveyor due to PSReadline issue Nov 20, 2018
@anmenaga

Andrew (anmenaga) commented Nov 20, 2018

Copy link
Copy Markdown

Something is not right; CI's are failing for this change.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Nov 20, 2018
View reviewed changes
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Nov 20, 2018
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Enter-PSHostProcess.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Aditya Patwardhan (adityapatwardhan) added 2 commits November 19, 2018 18:09
@adityapatwardhan
[Feature]
04f7ffb
@adityapatwardhan
[Feature] Fix typo
561d550
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) force-pushed the FixEnterPSHostProcessTests branch from 5a0d7dd to 561d550 Compare November 20, 2018 02:12
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Nov 20, 2018
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Enter-PSHostProcess.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan
[Feature] Add Skip for AppVeyor
168a8f3
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Nov 20, 2018
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit f27dfea into PowerShell:master Nov 20, 2018
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the FixEnterPSHostProcessTests branch November 20, 2018 18:17
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Nov 21, 2018
Ilya (iSazonov) pushed a commit to iSazonov/PowerShell that referenced this pull request Nov 29, 2018
@adityapatwardhan @iSazonov
Skip Enter-PSHostProcess tests on Appveyor due to PSReadline issue (P…
336b7be
…owerShell#8317)
@iSazonov Ilya (iSazonov) assigned Aditya Patwardhan (adityapatwardhan) Dec 8, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Skip Enter-PSHostProcess tests on Appveyor due to PSReadline issue (P…
9a4abf1
…owerShell#8317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@adityapatwardhan @anmenaga @SteveL-MSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.