GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Cleanup updatablehelpsystem and enable XSD validation on MAML help content by iSazonov · Pull Request #8335 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Nov 26, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Related #3565 and #4357.

Easily review commit by commit:

  • Remove old code for WebClient - currently HTTPClient is main in CoreFX.
  • Restore XML Schema support - currently we have the API in CoreFX.
  • Reorder using statements.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov Ilya (iSazonov) self-assigned this Nov 26, 2018
@iSazonov
Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Dongbo Wang (daxian-dbw) November 26, 2018 04:48
@iSazonov
Ilya (iSazonov) requested review from Francisco Gamino (Francisco-Gamino) and Aditya Patwardhan (adityapatwardhan) as code owners November 26, 2018 04:48
@iSazonov

Ilya (iSazonov) commented Nov 26, 2018

Copy link
Copy Markdown
Collaborator Author

Tests failed with "The Help content XSD file cannot be found in C:\projects\powershell\src\powershell-win-core\bin\Release"

I see that Windows PowerShell has Schemas directory in home folder.

Should we restore this or remove schemas support?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 27, 2018

Copy link
Copy Markdown
Member

Ilya (@iSazonov) Thanks for this PR. We should bring back the schema files as XSD validation seems to be supported in CoreCLR now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Nov 28, 2018

Copy link
Copy Markdown
Collaborator Author

Aditya Patwardhan (@adityapatwardhan) Please point me where I can get this files from. Can I copy them to the repo from Windows PowerShell directory?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Ilya (iSazonov) added 4 commits November 29, 2018 18:37
@iSazonov
Remove WebClient code
ab39905
@iSazonov
CoreFX now supports XML Schemas
4ad09b3
@iSazonov
Reorder using-s
5362f58
@iSazonov
Publish Schemas
2bf264c
@iSazonov
Ilya (iSazonov) force-pushed the cleanup-updatablehelpsystem branch from 74aca01 to 2bf264c Compare November 29, 2018 13:53
@iSazonov
Ilya (iSazonov) requested review from Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13) and Andrew (anmenaga) as code owners November 29, 2018 13:53
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 29, 2018
Ilya (iSazonov) added 2 commits November 29, 2018 19:28
@iSazonov
Publish Schemas on Unix
33072dc
@iSazonov
Upadate files.wxs
c1efed6
@iSazonov

Ilya (iSazonov) commented Nov 29, 2018

Copy link
Copy Markdown
Collaborator Author

Aditya Patwardhan (@adityapatwardhan) Schemas added.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Nov 29, 2018
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the title to mention enable XSD validation of maml help

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title Cleanup updatablehelpsystem Cleanup updatablehelpsystem and enable XSD validation on MAML help content Nov 29, 2018
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) assigned Aditya Patwardhan (adityapatwardhan) and unassigned Ilya (iSazonov) Nov 29, 2018
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 6dcd3ad into PowerShell:master Nov 29, 2018
@iSazonov
Ilya (iSazonov) deleted the cleanup-updatablehelpsystem branch November 30, 2018 03:12
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov @adityapatwardhan
Cleanup updatablehelpsystem and enable XSD validation on MAML help co…
5552ca3 
…ntent (PowerShell#8335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
@Francisco-Gamino Francisco Gamino (Francisco-Gamino) Awaiting requested review from Francisco-Gamino
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@iSazonov @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.