GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Cleanup '#if !CORECLR' code by iSazonov · Pull Request #8337 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Nov 26, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Related #3565 and #4357.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Ilya (iSazonov) added 7 commits November 26, 2018 15:32
@iSazonov
NewWinEventCommand.cs
fbe70e8
@iSazonov
CredSSP.cs
677e704
@iSazonov
WsManHelper.cs
7639693
@iSazonov
debugger.cs
981090f
@iSazonov
InternalHost.cs
25adfc2
@iSazonov
InitialSessionState.cs
235b082
@iSazonov
BaseTransportManager.cs
8ac7782
@iSazonov Ilya (iSazonov) self-assigned this Nov 26, 2018
@iSazonov
Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Dongbo Wang (daxian-dbw) November 26, 2018 11:26
@iSazonov
Ilya (iSazonov) requested review from Bruce Payette (BrucePay), Paul Higinbotham (PaulHigin), Andrew (anmenaga) and Mike Richmond (mirichmo) as code owners November 26, 2018 11:26
Ilya (iSazonov) added 2 commits November 26, 2018 17:51
@iSazonov
Types_Ps1Xml.cs
bf294a1
@iSazonov
FileSystemProvider.cs
cc33627
@iSazonov
Ilya (iSazonov) force-pushed the cleanup-corecrl2 branch from af4245f to cc33627 Compare November 26, 2018 12:52
@iSazonov
Ilya (iSazonov) requested review from Travis Plunk (TravisEz13) and Aditya Patwardhan (adityapatwardhan) as code owners November 26, 2018 12:52
TravisEz13
Travis Plunk (TravisEz13) approved these changes Nov 26, 2018
View reviewed changes
anmenaga
Andrew (anmenaga) reviewed Nov 28, 2018
View reviewed changes
Comment thread src/Microsoft.WSMan.Management/CredSSP.cs
, RegistryKeyPermissionCheck.ReadWriteSubTree
#endif
);
Credential_Delegation_Key = rootKey.CreateSubKey(Registry_Path_Credentials_Delegation, RegistryKeyPermissionCheck.ReadWriteSubTree);

@anmenaga Andrew (anmenaga) Nov 28, 2018

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you decide to add RegistryKeyPermissionCheck parameter here?
It looks like the macro was removing it previously...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Nov 29, 2018

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it was removed because CoreFX had not support. Now we have this and we can enable the check.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Nov 28, 2018
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Diagnostics/NewWinEventCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/remoting/fanin/BaseTransportManager.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov
Restore XmlResolver = null
5a870fc
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 29, 2018
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Nov 30, 2018
View reviewed changes
@iSazonov
Ilya (iSazonov) merged commit 4e58ee6 into PowerShell:master Nov 30, 2018
@iSazonov
Ilya (iSazonov) deleted the cleanup-corecrl2 branch November 30, 2018 03:11
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov
Cleanup '#if !CORECLR' code (PowerShell#8337)
689e710 
* NewWinEventCommand.cs
* CredSSP.cs
* WsManHelper.cs
* debugger.cs
* InternalHost.cs
* InitialSessionState.cs
* BaseTransportManager.cs
* Types_Ps1Xml.cs
* FileSystemProvider.cs
* Restore XmlResolver = null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
@mirichmo Mike Richmond (mirichmo) Awaiting requested review from mirichmo
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
+1 more reviewer
@anmenaga Andrew (anmenaga) anmenaga left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iSazonov @TravisEz13 @SteveL-MSFT @anmenaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.