GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Adding yml for Windows Release builds by anmenaga · Pull Request #8374 · PowerShell/PowerShell

Conversation

Andrew (anmenaga) commented Nov 30, 2018

Copy link

Copy Markdown

PR Summary

As part of improving the build process, the UI build pipeline for Windows Builds was converted to a yml-based pipeline. (everything minus compliance tasks)
Verified on AzureDevOps mirror (pipeline WIP-PowerShellCore-WindowsBuild-Yaml): automated and manual runs.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
User-facing changes
- Not Applicable
- OR
- User-facing Documentation needed
  - Issue filed - Issue link:
Testing - New and feature
- Not Applicable or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
  - Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Andrew Menagarishvili added 18 commits

November 12, 2018 11:59


          WindowsBuild 1

8104c63


          WindowsBuild 2

adebb5d


          WindowsBuild 3

c7456c4


          WindowsBuild 4

b6b57ba


          WindowsBuild 5

ee778d2


          WindowsBuild 6

16b0bf9


          WindowsBuild 7

62ec6bc


          WindowsBuild 8

732f9d2


          WindowsBuild 9

2fac3f4


          WindowsBuild 10

0be5e8a


          WindowsBuild 11

54965c0


          WindowsBuild 12

41c0bf2


          WindowsBuild 13

47bc82c


          WindowsBuild 14

d4bd1ad


          WindowsBuild 15

1b5f26e


          WindowsBuild 16

af5c4f1


          WindowsBuild 17

7e614e2


          WindowsBuild.yml 47

ff019ed

Andrew (anmenaga) added the WG-Maintainers-Build specific to affecting the build label

Nov 30, 2018

Andrew (anmenaga) assigned Aditya Patwardhan (adityapatwardhan)

Nov 30, 2018

Andrew (anmenaga) requested review from Travis Plunk (TravisEz13) and Aditya Patwardhan (adityapatwardhan)

November 30, 2018 19:07

Andrew (anmenaga) requested review from Paul Higinbotham (PaulHigin) and Dongbo Wang (daxian-dbw) as code owners

November 30, 2018 19:07

Aditya Patwardhan (adityapatwardhan) requested changes

Nov 30, 2018

View reviewed changes

Comment thread

tools/releaseBuild/azureDevOps/WindowsBuild.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

tools/releaseBuild/azureDevOps/WindowsBuild.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

tools/releaseBuild/azureDevOps/WindowsBuild.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

tools/releaseBuild/azureDevOps/WindowsBuild.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.


          WindowsBuild.yml 48

32688de

Andrew (anmenaga) commented Dec 4, 2018

Copy link

Copy Markdown

Author

Fixed CodeFactor issues.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Andrew (anmenaga) commented Dec 4, 2018

Copy link

Copy Markdown

Author

Aditya Patwardhan (@adityapatwardhan) pls look again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) changed the title ~~Adding yml for Windows builds~~ Adding yml for Windows Release builds

Dec 5, 2018


          WindowsBuild.yml 50

fc839dd


          WindowsBuild.yml 51

c274136

Travis Plunk (TravisEz13) reviewed

Dec 5, 2018

View reviewed changes

Comment thread

tools/releaseBuild/azureDevOps/WindowsBuild.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) reviewed

Dec 5, 2018

View reviewed changes

Travis Plunk (TravisEz13) left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than comments

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Removed manual creation of target Azure container

5a99168

Travis Plunk (TravisEz13) approved these changes

Dec 5, 2018

View reviewed changes

Aditya Patwardhan (adityapatwardhan) approved these changes

Dec 5, 2018

View reviewed changes

Aditya Patwardhan (adityapatwardhan) left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments are non-blocking

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tools/releaseBuild/azureDevOps/WindowsBuild.yml Outdated


		- powershell: \|
		docker container prune --force
		docker container ls --all --format '{{ json .ID }}' \| ConvertFrom-Json \| %{docker container rm --force --volumes $_}

Aditya Patwardhan (adityapatwardhan) Dec 5, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change % to ForEach-Object

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tools/releaseBuild/azureDevOps/WindowsBuild.yml Outdated

		condition: and(succeeded(), ne(variables['SkipFxDependent'], 'true'))

		- powershell: \|
		docker image ls --format '{{ json .}}'\|ConvertFrom-Json\|% {

Aditya Patwardhan (adityapatwardhan) Dec 5, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change % to ForEach-Object

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tools/releaseBuild/azureDevOps/WindowsBuild.yml Outdated


		- powershell: \|
		docker container prune --force
		docker container ls --all --format '{{ json .ID }}' \| ConvertFrom-Json \| %{docker container rm --force --volumes $_}

Aditya Patwardhan (adityapatwardhan) Dec 5, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change % to ForEach-Object

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tools/releaseBuild/azureDevOps/WindowsBuild.yml Outdated

		continueOnError: true

		- powershell: \|
		docker image ls --format '{{ json .}}'\|ConvertFrom-Json\|% {

Aditya Patwardhan (adityapatwardhan) Dec 5, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change % to ForEach-Object

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          WindowsBuild.yml 54

2f20add

Travis Plunk (TravisEz13) approved these changes

Dec 7, 2018

View reviewed changes

Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label

Dec 7, 2018

Travis Plunk (TravisEz13) merged commit a1299cd into PowerShell:master

Dec 7, 2018

Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request

May 14, 2019


          Adding yml for Windows Release builds (PowerShell#8374)

818050d

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Adding yml for Windows Release builds (PowerShell#8374)

9b5c4f7

Reviewers

Travis Plunk (TravisEz13)

TravisEz13 approved these changes

Aditya Patwardhan (adityapatwardhan)

adityapatwardhan approved these changes

Dongbo Wang (daxian-dbw)

Awaiting requested review from daxian-dbw

Paul Higinbotham (PaulHigin)

Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Aditya Patwardhan (adityapatwardhan)

Labels

CL-BuildPackaging

Indicates that a PR should be marked as a build or packaging change in the Change Log

WG-Maintainers-Build

specific to affecting the build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.