GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "Remove workaround for fixed invalid json array deserializing bug (#8346)" by TravisEz13 · Pull Request #8375 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Nov 30, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Revert "Remove workaround for fixed invalid json array deserializing bug (#8346)"

This reverts commit 60a4e2f.

This change caused the test which verified the functionality this workaround enabled, to start failing

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Travis Plunk (TravisEz13) requested review from James Truher (JamesWTruher) and Paul Higinbotham (PaulHigin) as code owners November 30, 2018 21:06
@TravisEz13
[Feature] Revert "Remove workaround for fixed invalid json array dese…
d37e871 
…rializing bug (PowerShell#8346)"

This reverts commit 60a4e2f.
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the revert_8346 branch from 92eaacc to d37e871 Compare November 30, 2018 21:07
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Nov 30, 2018
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 2a469b7 into PowerShell:master Nov 30, 2018
@TravisEz13
Travis Plunk (TravisEz13) deleted the revert_8346 branch November 30, 2018 22:32
@TravisEz13

Travis Plunk (TravisEz13) commented Nov 30, 2018

Copy link
Copy Markdown
Member Author

See comments on #8346 about what tests were failing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-NotInBuild Indicates that a PR is reverted and not part of the build. label Dec 5, 2018
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Dec 8, 2018
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Jul 25, 2022
Remove pre-parse for array-based JSON #15684
Merged
8 of 22 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Revert "Remove workaround for fixed invalid json array deserializing …
d7c69ef 
…bug (PowerShell#8346)" (PowerShell#8375)

Revert "Remove workaround for fixed invalid json array deserializing bug (PowerShell#8346)"

This reverts commit fbe7090.

This change caused the test which verified the functionality this workaround enabled, to start failing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-NotInBuild Indicates that a PR is reverted and not part of the build.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@TravisEz13 @daxian-dbw @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.