GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Change Newtonsoft deserializing bug comment to link to the new issue by adamgauthier · Pull Request #8377 · PowerShell/PowerShell

Conversation

@adamgauthier

@adamgauthier Adam Gauthier (adamgauthier) commented Dec 1, 2018

Copy link
Copy Markdown
Contributor

PR Summary

This is a follow up to reverted PR #8346. I removed a workaround that was used to avoid a Newtonsoft.Json bug that caused some incomplete json array input to successfully be deserialized.

This bug being fixed, I thought the workaround was unnecessary, but after the merge some feature tests started to fail (which I did not run prior to merging).

It was discovered that the workaround is still needed because while the first Newtonsoft.Json bug was fixed, some cases of incomplete json array input still behave unexpectedly, namely json input [.

This PR is just to update the comment explaining the workaround so it links to the newly created issue here.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
  • Testing - New and feature
    • Not Applicable or can only be tested interactively

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adamgauthier
Change Newtonsoft deserializing bug comment to link to the new issue
0561af1
@adamgauthier
Adam Gauthier (adamgauthier) requested review from James Truher (JamesWTruher) and Paul Higinbotham (PaulHigin) as code owners December 1, 2018 10:13
iSazonov
Ilya (iSazonov) approved these changes Dec 2, 2018
View reviewed changes
@iSazonov
Ilya (iSazonov) requested a review from Travis Plunk (TravisEz13) December 2, 2018 15:10
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Dec 2, 2018
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Dec 3, 2018
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) approved these changes Dec 3, 2018
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit d150871 into PowerShell:master Dec 3, 2018
@TravisEz13 Travis Plunk (TravisEz13) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 3, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adamgauthier @TravisEz13
Change Newtonsoft deserializing bug comment to link to the new issue (P…
a9dc28d 
…owerShell#8377)

This is a follow up to reverted PR PowerShell#8346. I removed a workaround that was used to avoid [a Newtonsoft.Json bug](JamesNK/Newtonsoft.Json#1321) that caused some incomplete json array input to successfully be deserialized.

This bug being fixed, I thought the workaround was unnecessary, but after the merge some feature tests started to fail (which I did not run prior to merging).

It was discovered that the workaround is still needed because while the first Newtonsoft.Json bug was fixed, some cases of incomplete json array input still behave unexpectedly, namely json input `[`. 

This PR is just to update the comment explaining the workaround so it links to the newly created issue [here](JamesNK/Newtonsoft.Json#1930).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
+1 more reviewer
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@adamgauthier @TravisEz13 @PaulHigin @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.