GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove dependabot attribution and generate changelog sections using `CL-*` labels by adityapatwardhan · Pull Request #8386 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Dec 3, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

  • Remove dependabot attribution from change log.
  • Create sections in generated change log using the CL-* labels.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan
Remove dependabot attribution and generate changelog sections using `…
b08d377 
…CL-*` labels
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Travis Plunk (TravisEz13) and Dongbo Wang (daxian-dbw) December 3, 2018 20:35
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Paul Higinbotham (PaulHigin) and Andrew (anmenaga) as code owners December 3, 2018 20:35
PaulHigin
Paul Higinbotham (PaulHigin) suggested changes Dec 3, 2018
View reviewed changes
Comment thread tools/releaseTools.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/releaseTools.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/releaseTools.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Address Paul's CR feedback
655bbb2
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Dec 3, 2018

Copy link
Copy Markdown
Member Author

Paul Higinbotham (@PaulHigin) I updated the PRs, please have another look.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Dec 3, 2018
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) reviewed Dec 3, 2018
View reviewed changes
Comment thread tools/releaseTools.psm1
@@ -1,3 +1,5 @@
#requires -Version 6.0

@TravisEz13 Travis Plunk (TravisEz13) Dec 3, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our guidance says the copyright has to be first... This is obviously a reasonable exception, but should we update the guidance?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Dec 3, 2018
View reviewed changes

@PaulHigin Paul Higinbotham (PaulHigin) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Travis Plunk (TravisEz13) merged commit 13cf8af into PowerShell:master Dec 3, 2018
@iSazonov

Ilya (iSazonov) commented Dec 4, 2018

Copy link
Copy Markdown
Collaborator

How do we track unlabeled commits and reverted commits?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Dec 4, 2018

Copy link
Copy Markdown
Member

if the commit was reverted in the same release use CL-NotInBuild for both the original and the revert commit.

The script will ward about any PRs without labels. Any final commits that are created during the release process outside of the PR process will have to be categorized manually.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Dec 6, 2018
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Dec 8, 2018
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the UpdateCLScript branch January 8, 2019 18:55
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan @TravisEz13
Remove dependabot attribution and generate changelog sections using `…
b66f3a2 
…CL-*` labels (PowerShell#8386)

* Remove dependabot attribution from change log.
* Create sections in generated change log using the `CL-*` labels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
+1 more reviewer
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@adityapatwardhan @iSazonov @TravisEz13 @PaulHigin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.