GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — `Start-Transcript` Add option to minimise transcript header · Pull Request #8402 · PowerShell/PowerShell

Conversation

@ghost

@ghost Deleted user (ghost) commented Dec 5, 2018 •
edited by iSazonov
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

PR Summary

Add a switch parameter UseMinimalHeader to Start-Transcript. When used, a transcript will contain a short header like the following, instead of the usual header containing version information.

**********************
PowerShell transcript start
Start time: 20181201203347
**********************

This partly addresses #8359.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost
ghost requested review from Bruce Payette (BrucePay), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners December 5, 2018 11:46
@iSazonov

Ilya (iSazonov) commented Dec 7, 2018

Copy link
Copy Markdown
Collaborator

@lukexjeremy Thanks for your contribution!
You could look Start-Transcript.Tests.ps1 for tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Luke Jeremy (lukej57) added 3 commits December 8, 2018 17:57
@lukej57
Start-Transcript: Add -MinimalTranscriptHeader switch parameter
3e04787 
(#8359)
@lukej57
Address CodeFactor feedback
30ed8df
@lukej57
Add test for MinimalTranscriptHeader parameter
7633b87
@ghost ghost changed the title WIP: Start-Transcript Add option to minimise transcript header Start-Transcript Add option to minimise transcript header Dec 16, 2018
@iSazonov Ilya (iSazonov) assigned Dongbo Wang (daxian-dbw) Dec 16, 2018
daxian-dbw
Dongbo Wang (daxian-dbw) requested changes Dec 19, 2018
View reviewed changes
Comment thread src/Microsoft.PowerShell.ConsoleHost/host/msh/StartTranscriptCmdlet.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/Microsoft.PowerShell.ConsoleHost/host/msh/StartTranscriptCmdlet.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/hostifaces/MshHostUserInterface.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested a review from Paul Higinbotham (PaulHigin) December 19, 2018 01:40
@lukej57
Address review comments
8751aa4
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Dec 19, 2018
View reviewed changes
daxian-dbw
Dongbo Wang (daxian-dbw) requested changes Dec 19, 2018
View reviewed changes
Comment thread src/Microsoft.PowerShell.ConsoleHost/host/msh/StartTranscriptCmdlet.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.Powershell.Host/Start-Transcript.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 19, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@lukexjeremy On another thought, -UseShortHeader might be a better choice as you only have two options: the regular header and the short header, while minimal seems suggesting you have at least 3 options for the header. What do you think?

At the meantime, let me consult with the team members and reply back what they think. Chatted with my teammates offline, and there is a slight preference toward -UseMinimalHeader. So let's stick to that name 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Luke Jeremy (lukej57) added 2 commits December 20, 2018 07:29
@lukej57
Correct parameter name in test
44d5720
@lukej57
Correct outdated comment
b9c55e5
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Dec 19, 2018
View reviewed changes
@ghost ghost mentioned this pull request Dec 20, 2018
Document new UseMinimalHeader switch parameter for Start-Transcript MicrosoftDocs/PowerShell-Docs#3457
Closed
2 of 8 tasks
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 20, 2018

Copy link
Copy Markdown
Member

@lukexjeremy Thank you for opening the doc issue. I forgot that myself :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 56fc426 into PowerShell:master Dec 20, 2018
@sdwheeler Sean Wheeler (sdwheeler) mentioned this pull request Dec 21, 2018
Document UseMinimalHeader switch on Start-Transcript MicrosoftDocs/PowerShell-Docs#3460
Merged
2 of 9 tasks
@ghost
ghost deleted the transcript-minimalheader branch December 21, 2018 22:45
@PaulHigin Paul Higinbotham (PaulHigin) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 24, 2019
@ghost ghost mentioned this pull request Apr 13, 2019
Feature Request: Transcript customisation #9354
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@lukej57 @daxian-dbw
Add -UseMinimalHeader to Start-Transcript to minimize transcript …
7f6461f 
…header (PowerShell#8402)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iSazonov @daxian-dbw @PaulHigin @lukej57
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.