GeezerVison is showing github.com — Remove unneeded catch/throw from 'mkdir' and 'oss' functions by daxian-dbw · Pull Request #8425 · PowerShell/PowerShell
Conversation
PR Summary
Remove unneeded catch/throw from 'mkdir' and 'oss' functions.
PR Checklist
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Dongbo Wang (@daxian-dbw) - sorry to have just noticed this - the seemingly unnecessary try/catch statements did serve a useful purpose at one point. I recall hating adding them, but IIRC, it improved error reporting in some useful way. Sorry, but I don't remember more than that though.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Does it update ScriptStackTrace in errorrecord?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Jason Shirk (@lzybkr) Thanks for bringing up that context. Looks like those try/catch were added only for functions that uses SteppablePipeline. Might it be related to errors thrown from within the steppable pipeline? I will play with it a bit to see if I can find out why.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
The "better error reporting" might be related to PowerShell.AddScript(...).Invoke() doesn't throw on terminating error or exception, but instead keep the errors in the error stream.
Here is one example of that:
$ps = [powershell]::create()
$ps.AddScript(@'
try {
Get-Process -Invalid 42
} catch {
throw
}
'@)
## try/catch/throw is needed for the exception to be thrown from $ps.invoke()
$ps.Invoke()
But it doesn't seem to be the exact reason for the try/catch/throw in the original mkdir and oss.
The following throws the exception even without the try/catch/throw in mkdir:
$ps = [powershell]::create()
$ps.AddScript("mkdir -Path blahhfe:\jkfjkjakfklajlkf -ea stop") > $null
$ps.Invoke()
|
iSazonov reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Labels
CL-CodeCleanup
Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|