GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make scriptblock-based calculated properties work again in ConvertTo-Html by mklement0 · Pull Request #8427 · PowerShell/PowerShell

Conversation

@mklement0

@mklement0 Michael Klement (mklement0) commented Dec 8, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Fixes #6993

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mklement0
Fixes PowerShell#6993
6206919 
Make scriptblock-based calculated properties work again.
@mklement0
Michael Klement (mklement0) requested review from James Truher (JamesWTruher) and Paul Higinbotham (PaulHigin) as code owners December 8, 2018 02:42
@mklement0
CodeFactor changes
715f120
@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 8, 2018
iSazonov
Ilya (iSazonov) reviewed Dec 8, 2018
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michael Klement (@mklement0) Please add a commit with [Feature] in title to run full test set.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/convert-HTML.cs Outdated
}
else
{
// property name

@iSazonov Ilya (iSazonov) Dec 8, 2018

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the obvious comment and enhance comment in line 346.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mklement0 Michael Klement (mklement0) Dec 8, 2018

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ilya (@iSazonov): Done. Is it sufficient to add "[Feature]" in the first line of a commit message once?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@iSazonov
Ilya (iSazonov) requested a review from Mark Kraus (markekraus) December 8, 2018 10:43
@mklement0
[Feature] Trigger feature test; comments amended
8c2729a
iSazonov
Ilya (iSazonov) approved these changes Dec 8, 2018
View reviewed changes
@mklement0 Michael Klement (mklement0) mentioned this pull request Dec 8, 2018
[Feature] Define short alias names for all keys supported in calculated-property definitions #8430
Closed
6 of 11 tasks
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Dec 10, 2018
View reviewed changes
@iSazonov Ilya (iSazonov) self-assigned this Dec 11, 2018
@mklement0 Michael Klement (mklement0) mentioned this pull request Jan 8, 2019
Allow 'name' as an alias key for 'label' in ConvertTo-Html, allow the 'width' entry to be an integer #8426
Merged
7 of 11 tasks
@iSazonov

Ilya (iSazonov) commented Jan 9, 2019

Copy link
Copy Markdown
Collaborator

Michael Klement (@mklement0) Sorry, I lost the PR :-( Do we ready to merge?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mklement0

Michael Klement (mklement0) commented Jan 9, 2019

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov): From my perspective, yes. Can you squash-merge, or do I need to consolidate the commits myself?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov
Ilya (iSazonov) merged commit 73716e9 into PowerShell:master Jan 9, 2019
@iSazonov

Ilya (iSazonov) commented Jan 9, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Michael Klement (@mklement0) Maintainers can squash and merge as needed. Thanks for your contribution!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mklement0

Michael Klement (mklement0) commented Jan 9, 2019

Copy link
Copy Markdown
Contributor Author

That's good to know, Ilya (@iSazonov) - thanks for merging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mklement0
Michael Klement (mklement0) deleted the convertto-html-script-block-fix branch January 9, 2019 08:57
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@mklement0 @iSazonov
Make scriptblock-based calculated properties work again in ConvertTo-…
0295405 
…Html (PowerShell#8427)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
@markekraus Mark Kraus (markekraus) Awaiting requested review from markekraus

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Passing calculated properties to ConvertTo-Html is broken

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mklement0 @iSazonov @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.